Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AggregateAttestationAndProof #79

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Add AggregateAttestationAndProof #79

merged 1 commit into from
Dec 11, 2019

Conversation

terencechain
Copy link
Member

Added aggregate attestation and proof message

@terencechain terencechain self-assigned this Dec 11, 2019
@@ -33,6 +33,17 @@ message Attestation {
bytes signature = 3;
}

message AggregateAttestationAndProof {
// index is the aggregator's index
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use proper sentence format. Capitalize first letter and add punctuation

@terencechain terencechain merged commit 5ade052 into v0.9.2 Dec 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the aggregate branch December 11, 2019 15:51
@terencechain
Copy link
Member Author

Sorry merged too quick. Will address @prestonvanloon feedback now

rauljordan added a commit that referenced this pull request Jan 7, 2020
* Removed custody bits

* Mirror change in master in 0.9.2 (#73)

* mod validator proto

* regen

* sync protos

* Include Validator Indices in Common Validator List Responses (#75)

* Align Duties Response With v0.9.2 (#77)

* standardize spacing (#78)

* Added AggregateAttestationAndProof (#79)

* Update AggregateAttestationAndProof (#80)

* Added AggregateAttestationAndProof

* Better comments

* Update attestation.proto

* Revert 2a889fe

* Rm signing root changes (#90)

* Updated messages

* Generate pb.go

* use signed block in block container

* Propose signed objects

* fix protos

* regen

Co-authored-by: Jim McDonald <Jim@mcdee.net>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants