Include Validator Indices in Common Validator List Responses #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
Dec 10, 2019
rauljordan
added a commit
that referenced
this pull request
Jan 7, 2020
* Removed custody bits * Mirror change in master in 0.9.2 (#73) * mod validator proto * regen * sync protos * Include Validator Indices in Common Validator List Responses (#75) * Align Duties Response With v0.9.2 (#77) * standardize spacing (#78) * Added AggregateAttestationAndProof (#79) * Update AggregateAttestationAndProof (#80) * Added AggregateAttestationAndProof * Better comments * Update attestation.proto * Revert 2a889fe * Rm signing root changes (#90) * Updated messages * Generate pb.go * use signed block in block container * Propose signed objects * fix protos * regen Co-authored-by: Jim McDonald <Jim@mcdee.net> Co-authored-by: Raul Jordan <raul@prysmaticlabs.com> Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @shayzluf for bringing this up. The slasher service supported by Prysm here: https://github.com/prysmaticlabs/prysm/tree/master/slasher frequently requires data from the beacon node, specifically, validator data. Some of our RPC responses such as
ListValidatorsandGetActiveSetChangesreturn lists of validators and public keys, but for slashing in particular, it's important for these responses to also contain validator indices. This PR amends the responses accordingly.