Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AggregateAttestationAndProof #80

Merged
merged 3 commits into from
Dec 11, 2019
Merged

Update AggregateAttestationAndProof #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
930049e
Added AggregateAttestationAndProof
terencechain Dec 11, 2019
5c55520
Merge branch 'v0.9.2' of https://github.com/prysmaticlabs/ethereumapi…
terencechain Dec 11, 2019
c0a9655
Better comments
terencechain Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 39 additions & 38 deletions eth/v1alpha1/attestation.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions eth/v1alpha1/attestation.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@ message Attestation {
}

message AggregateAttestationAndProof {
// index is the aggregator's index
uint64 index = 1;
// The aggregator index that submitted this aggregated attestation and proof.
uint64 aggregator_index = 1;

// selection_proof is the signature of the slot aggregator signed to
bytes selection_proof = 2;

// aggregate is the constructed aggregated attestation
// The aggregated attestation that was submitted.
Attestation aggregate = 3;

// The selection proof signed by the aggregator, which is the signature of the slot to aggregate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the bytes size. Is this 96 bytes signature?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fe50924

bytes selection_proof = 2;
}

message AttestationData {
Expand Down