Move legacy primer/primitives into Primer React
#3787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d43bf4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
langermank
had a problem deploying
to
github-pages
GitHub Actions
Failure
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
reviewed
Oct 5, 2023
src/legacy-theme/js/colors/light.js
Outdated
| @@ -0,0 +1,602 @@ | |||
| const colors = { | |||
There was a problem hiding this comment.
Could these files be .ts with the variable set as const? This could mean that the files are checked with TypeScript and we don't have to check-in the generated definition files.
There was a problem hiding this comment.
Totally! Thanks, will make that change 😄
There was a problem hiding this comment.
@joshblack took a stab at converting it all to JS, can you give it a look? I don't totally know what I'm doing.
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
approved these changes
Jan 17, 2024
Co-authored-by: Josh Black <joshblack@github.com>
Co-authored-by: Josh Black <joshblack@github.com>
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/github/primer/issues/2054
As we gear up for Primitives v8 (next major) I'm looking for ways we can stopgap the breaking change to provide more time for Primer libraries to upgrade. This PR copies the
distthat Primer React depends on directly into Primer React which allows us to remove it from Primitives. The only thing truly referenced from Primitives are colors, while most other values were hand written in the theme file.Goals:
Changelog
New
distfromprimer/primitivesand removes dependencyChanged
Rollout strategy
Testing & Reviewing
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.