-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move legacy primer/primitives into Primer React
#3787
Merged
Merged
Changes from 7 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e5cb463
move legacy primitives to prc
langermank c16142c
use es modules
langermank 65e2704
cleanup
langermank a252a74
lint
langermank 18a23b9
just get rid of typography sheesh
langermank 69be995
readme
langermank c7740d6
Merge branch 'main' into temp-legacy-primitives
langermank 5fd8a65
move to ts
langermank 8f44216
Merge branch 'temp-legacy-primitives' of https://github.com/primer/re…
langermank 87bfe21
more ts
langermank 7e31496
fix import
langermank f96ac18
feedback
langermank 4079e7e
delete d.ts file
langermank 305d7d8
add codeowner
langermank f72672d
add new tokens
langermank 6c1c579
ts directory
langermank 94007f5
test(vrt): update snapshots
langermank b5ccc28
Create dry-bugs-act.md
langermank 6dcc321
Update src/theme.ts
langermank 06b10ad
Update CODEOWNERS
langermank ba1e28e
Merge branch 'main' into temp-legacy-primitives
langermank 585214b
lint
langermank 2dd2649
fix inactive button color
langermank 3cff070
fix inactive for real
langermank 3d43bf4
test(vrt): update snapshots
langermank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| `legacy-theme` is a copy of the colors `dist` from `primer/primitives` and is intended to serve as a stopgap until we migrate JS variables to CSS variables. This excludes the build logic from Primitives, so each value is a raw hex. Refrain from making changes to these colors unless absolutely necessary. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thank you! ✨
Do you mind being the gatekeeper for legacy-theme by adding yourself as the CODEOWNER? That way github should notify you anytime there are changes