Skip to content

Commit

Permalink
Move legacy primer/primitives into Primer React (#3787)
Browse files Browse the repository at this point in the history
* move legacy primitives to prc

* use es modules

* cleanup

* lint

* just get rid of typography sheesh

* readme

* move to ts

* more ts

* fix import

* feedback

* delete d.ts file

* add codeowner

* add new tokens

* ts directory

* test(vrt): update snapshots

* Create dry-bugs-act.md

* Update src/theme.ts

Co-authored-by: Josh Black <joshblack@github.com>

* Update CODEOWNERS

Co-authored-by: Josh Black <joshblack@github.com>

* lint

* fix inactive button color

* fix inactive for real

* test(vrt): update snapshots

---------

Co-authored-by: langermank <langermank@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@github.com>
  • Loading branch information
3 people committed Jan 17, 2024
1 parent f1c1825 commit c9d7421
Show file tree
Hide file tree
Showing 15 changed files with 5,501 additions and 6 deletions.
7 changes: 7 additions & 0 deletions .changeset/dry-bugs-act.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@primer/react": minor
---

- Moves legacy color primitives from `primer/primitives` directly into Primer React
- Cleans up unused dependencies on primitives other than color
- Preparing for the upgrade to CSS variables (Primitives v8)
1 change: 1 addition & 0 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# All changes should be reviewed by a member of the @react-reviewers team
* @primer/react-reviewers
./src/legacy-theme/ @langermank
1 change: 1 addition & 0 deletions src/legacy-theme/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
`legacy-theme` is a copy of the colors `dist` from `primer/primitives` and is intended to serve as a stopgap until we migrate JS variables to CSS variables. This excludes the build logic from Primitives, so each value is a raw hex. Refrain from making changes to these colors unless absolutely necessary.
Loading

0 comments on commit c9d7421

Please sign in to comment.