Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #1292

Merged
merged 5 commits into from
Jun 11, 2021
Merged

chore: update dependencies #1292

merged 5 commits into from
Jun 11, 2021

Conversation

dgreif
Copy link
Member

@dgreif dgreif commented Jun 11, 2021

Bumping all the base level dependencies (not docs) in hopes of clearing a bunch of dependabot PRs

  • Jest had a breaking change, which changed some defaults with timers and the default environment. I'm setting jsdom as our default for now, but we could use node as the default and only use jsdom for the files that actually need it. Here's the release notes for those interested: https://jestjs.io/blog/2021/05/25/jest-27
  • I updated TypeScript, but there is an issue with react-docgen-typescript that prevents us from going all the way to the latest ts version. Looks like it is fixed and should be released soon: TypeError: (tag.text || "").trim is not a function styleguidist/react-docgen-typescript#356
  • I did not update styled-components because it causes all of our snapshots to fail. It looks like v5 has some major performance improvements, so we should definitely consider updating soon.
  • @primer/primitives is currently on a canary build, so we should consider updating that soon as well. Would love input from @colebemis and @VanAnderson on why we are currently using a canary build.

@dgreif dgreif requested review from smockle and colebemis June 11, 2021 15:58
@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2021

🦋 Changeset detected

Latest commit: 93f9814

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/8WyNMsGKURitbw4m5ZpJMLQiYaUt
✅ Preview: https://primer-components-git-dep-bump-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview June 11, 2021 19:06 Inactive
@vercel vercel bot temporarily deployed to Preview June 11, 2021 19:10 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up, @dgreif! Let's bump @primer/primitives to latest in this PR as well 👍

@colebemis
Copy link
Contributor

@VanAnderson is going to run a quick test of @primer/primitives@latest in Memex to double-check that it's safe to upgrade

@vercel vercel bot temporarily deployed to Preview June 11, 2021 19:45 Inactive
@colebemis
Copy link
Contributor

This snapshot diff looks odd to me:

CleanShot 2021-06-11 at 12 56 16@2x

https://github.com/primer/components/runs/2806099805#step:7:2042

I think this is happening because prState.open.border changed from "rgba(0,0,0,0)" to "transparent"

@vercel vercel bot temporarily deployed to Preview June 11, 2021 20:15 Inactive
@vercel vercel bot temporarily deployed to Preview June 11, 2021 20:44 Inactive
@vercel vercel bot temporarily deployed to Preview June 11, 2021 21:27 Inactive
@dgreif dgreif enabled auto-merge (squash) June 11, 2021 21:28
@dgreif dgreif disabled auto-merge June 11, 2021 21:28
@dgreif dgreif enabled auto-merge (squash) June 11, 2021 21:29
@dgreif dgreif merged commit 4b64381 into main Jun 11, 2021
@dgreif dgreif deleted the dep-bump branch June 11, 2021 21:31
@github-actions github-actions bot mentioned this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants