Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styled-components dependencies #1298

Closed
dgreif opened this issue Jun 11, 2021 · 3 comments
Closed

Update styled-components dependencies #1298

dgreif opened this issue Jun 11, 2021 · 3 comments
Assignees
Labels
dependencies Pull requests that update a dependency file react

Comments

@dgreif
Copy link
Member

dgreif commented Jun 11, 2021

I recently updated most of the base-level dependencies (#1292). One that I elected to skip was styled-components, which has a major release with big perf improvements. I tried updating, but most of the snapshots needed to be updated and there were other issues with the tests. I don't think the changes are actually significantly breaking, but this bump should be handled separate from other dependency bumps so that it gets the proper attention it needs.

@dgreif dgreif added the dependencies Pull requests that update a dependency file label Jun 11, 2021
@moatorres
Copy link

My best guess is that the patch below is the origin of the issue.

From sc releases:

v5.2.0-test.10 + v5.2.0

Rework how components self-reference in extension scenarios (see #3236); should fix a bunch of subtle bugs around patterns like & + &

You might want to check issues 3236, 3265 and 3401 from styled-components repo.

@colebemis
Copy link
Contributor

Looks like there is an open issue with jest-styled-components (styled-components/jest-styled-components#276) that breaks our snapshot tests when we upgrade to v5.

I'd argue that this is a low priority for us to fix right now because, since styled-components is a peer dependency, consumers of Primer React can use v5 in their application without any changes on the Primer React side (Memex already uses v5).

@gaknoll gaknoll added the react label Oct 19, 2021
@colebemis
Copy link
Contributor

Closing this for now until we determine if we want to use styled-components long term: https://github.com/github/primer/issues/203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file react
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants