Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps-dev): bump typescript from 4.2.2 to 4.3.2 (#1302)" #1305

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

dgreif
Copy link
Member

@dgreif dgreif commented Jun 15, 2021

This reverts commit 0b8dc48

I mentioned this in #1292, but there is currently a bug with react-docgen-typescript (styleguidist/react-docgen-typescript#356) if you update TypeScript beyond 4.2.2. This only bug only shows up when you run storybook, which is why CI passed in #1302.

@dgreif dgreif requested a review from colebemis June 15, 2021 04:31
@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2021

⚠️ No Changeset found

Latest commit: 3ae1c31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/GRqgF7ACxz1zrnXNoa8wSdrg2tJa
✅ Preview: https://primer-components-git-revert-typescript-bump-primer.vercel.app

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Good catch!

@dgreif dgreif merged commit afb6fe5 into main Jun 15, 2021
@dgreif dgreif deleted the revert-typescript-bump branch June 15, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants