Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canceled Task shouldn't start running #4311

Closed
aleks-f opened this issue Nov 28, 2023 · 0 comments
Closed

Canceled Task shouldn't start running #4311

aleks-f opened this issue Nov 28, 2023 · 0 comments
Assignees

Comments

@aleks-f
Copy link
Member

aleks-f commented Nov 28, 2023

Describe the bug
if a Task is canceled before it starts running, it will run nevertheless and completely disregard the cancelation.

To Reproduce
Cancel a task before it is started; it may not happen every time, but it is certainly possible to happen because currently there are no internal status checks before actually running it.

Expected behavior
A canceled Task should not run.

@aleks-f aleks-f added the bug label Nov 28, 2023
@aleks-f aleks-f added this to the Release 1.13.0 milestone Nov 28, 2023
@aleks-f aleks-f self-assigned this Nov 28, 2023
aleks-f added a commit that referenced this issue Dec 5, 2023
matejk added a commit that referenced this issue Dec 9, 2023
* fix(NumericString): properly mark uIntToString deprecated #4304

* dev(runLibtests): allow to specify test to run

* fix(NotificationCenter): data race #4307

* fix(DirectoryWatcher): data race #4308

* fix(ArchiveStrategy): data race #4309

* fix(ActiveThread): data race #4310

* fix(Task): Cancelled Task shouldn't start running #4311 (WIP)

* fix(String): ignore clang loop unrolling warnings

* fix(TaskManager): task ownership #4311

* chore(FIFOEventTest): fix unused var warning; disable benchmark in test

* fix(Task): remove unnecessary mutex (and prevent cyclic locking reported by TSAN)

* fix(CryptoTest): disable testEncryptDecryptGCM

* fix(ci): typo

* fix(NotificationCenter): disable and clear observers in dtor (#4307)

---------

Co-authored-by: Matej Kenda <matejken@gmail.com>
@aleks-f aleks-f added the fixed label Dec 21, 2023
@aleks-f aleks-f closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant