Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumericString conversions inconsistencies #4304

Closed
aleks-f opened this issue Nov 27, 2023 · 0 comments
Closed

NumericString conversions inconsistencies #4304

aleks-f opened this issue Nov 27, 2023 · 0 comments
Assignees
@aleks-f
Labels
breaking A breaking change bug fixed
Milestone
Release 1.13.0

Comments

@aleks-f
Copy link
Member

aleks-f commented Nov 27, 2023

Numeric conversions allow some inconsistencies, such as eg. converting a negative integer to hex, and parsing a negative numeric string into hex. This will be prohibited in 1.13 - potentially a breaking change. uIntToStr functions will be deprecated in favor of conditionally compile-time enable_if'd intToStr
@aleks-f aleks-f added bug breaking A breaking change labels Nov 27, 2023
@aleks-f aleks-f added this to the Release 1.13.0 milestone Nov 27, 2023
@aleks-f aleks-f self-assigned this Nov 27, 2023
@aleks-f aleks-f changed the title Numeric string conversions inconsistencies NumericString conversions inconsistencies Nov 27, 2023
aleks-f added a commit that referenced this issue Nov 27, 2023
@aleks-f
fix(NumericString): conversions inconsistencies #4304
3ce1cb5
@aleks-f aleks-f added the fixed label Nov 27, 2023
aleks-f added a commit that referenced this issue Nov 27, 2023
@aleks-f @Archipel
3102 json lowercase hex (#4306)
57bc0bb 
* Made it possible to use lowercase hex numbers, also when encoding JSON (#3102)

Co-authored-by: Thomas Weyn <Thomas.Weyn@cebir.be>

* fix(JSONString): Remove deprecated toJSON functions #4305

* fix(NumericString): conversions inconsistencies #4304

---------

Co-authored-by: Archipel <thomas@weynwebworks.com>
Co-authored-by: Thomas Weyn <Thomas.Weyn@cebir.be>
aleks-f added a commit that referenced this issue Nov 28, 2023
@aleks-f
fix(NumericString): properly mark uIntToString deprecated #4304
e229195
matejk added a commit that referenced this issue Dec 9, 2023
@aleks-f @matejk
4307/8/9/10 data races (#4312)
1e90f64 
* fix(NumericString): properly mark uIntToString deprecated #4304

* dev(runLibtests): allow to specify test to run

* fix(NotificationCenter): data race #4307

* fix(DirectoryWatcher): data race #4308

* fix(ArchiveStrategy): data race #4309

* fix(ActiveThread): data race #4310

* fix(Task): Cancelled Task shouldn't start running #4311 (WIP)

* fix(String): ignore clang loop unrolling warnings

* fix(TaskManager): task ownership #4311

* chore(FIFOEventTest): fix unused var warning; disable benchmark in test

* fix(Task): remove unnecessary mutex (and prevent cyclic locking reported by TSAN)

* fix(CryptoTest): disable testEncryptDecryptGCM

* fix(ci): typo

* fix(NotificationCenter): disable and clear observers in dtor (#4307)

---------

Co-authored-by: Matej Kenda <matejken@gmail.com>
@aleks-f aleks-f closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleks-f aleks-f

Labels
breaking A breaking change bug fixed
Projects
None yet
Milestone
Release 1.13.0
Development

No branches or pull requests
1 participant
@aleks-f