-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActiveThread
data race
#4310
Comments
Thank you. I'll try to fix it. Mistakes make our life more interesting 😁 |
it is fixed already, I was just communicating for the future. |
Oh, ok. I understand. |
* fix(NumericString): properly mark uIntToString deprecated #4304 * dev(runLibtests): allow to specify test to run * fix(NotificationCenter): data race #4307 * fix(DirectoryWatcher): data race #4308 * fix(ArchiveStrategy): data race #4309 * fix(ActiveThread): data race #4310 * fix(Task): Cancelled Task shouldn't start running #4311 (WIP) * fix(String): ignore clang loop unrolling warnings * fix(TaskManager): task ownership #4311 * chore(FIFOEventTest): fix unused var warning; disable benchmark in test * fix(Task): remove unnecessary mutex (and prevent cyclic locking reported by TSAN) * fix(CryptoTest): disable testEncryptDecryptGCM * fix(ci): typo * fix(NotificationCenter): disable and clear observers in dtor (#4307) --------- Co-authored-by: Matej Kenda <matejken@gmail.com>
Describe the bug
Data race due to use of naked pointers.
To Reproduce
Thread sanitizer
Expected behavior
Clean run
Logs
Please add relevant environment information:
osx, clang TSAN build
@bas524 this is a good contribution, but please - whenever possible, make use of smart pointers, there's a good reason why they exist. and run the code through sanitizers on multiple platforms/compilers
The text was updated successfully, but these errors were encountered: