Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DirectoryWatcher data race #4308

Closed
aleks-f opened this issue Nov 28, 2023 · 0 comments
Closed

DirectoryWatcher data race #4308

aleks-f opened this issue Nov 28, 2023 · 0 comments
Assignees
@aleks-f
Labels
bug fixed
Milestone
Release 1.13.0

Comments

@aleks-f
Copy link
Member

aleks-f commented Nov 28, 2023

Describe the bug
_stopped flag not thread-safe

To Reproduce
Thread sanitizer
@aleks-f aleks-f added the bug label Nov 28, 2023
@aleks-f aleks-f added this to the Release 1.13.0 milestone Nov 28, 2023
@aleks-f aleks-f self-assigned this Nov 28, 2023
aleks-f added a commit that referenced this issue Nov 28, 2023
@aleks-f
fix(DirectoryWatcher): data race #4308
61dae36
matejk added a commit that referenced this issue Dec 9, 2023
@aleks-f @matejk
4307/8/9/10 data races (#4312)
1e90f64 
* fix(NumericString): properly mark uIntToString deprecated #4304

* dev(runLibtests): allow to specify test to run

* fix(NotificationCenter): data race #4307

* fix(DirectoryWatcher): data race #4308

* fix(ArchiveStrategy): data race #4309

* fix(ActiveThread): data race #4310

* fix(Task): Cancelled Task shouldn't start running #4311 (WIP)

* fix(String): ignore clang loop unrolling warnings

* fix(TaskManager): task ownership #4311

* chore(FIFOEventTest): fix unused var warning; disable benchmark in test

* fix(Task): remove unnecessary mutex (and prevent cyclic locking reported by TSAN)

* fix(CryptoTest): disable testEncryptDecryptGCM

* fix(ci): typo

* fix(NotificationCenter): disable and clear observers in dtor (#4307)

---------

Co-authored-by: Matej Kenda <matejken@gmail.com>
@matejk matejk added the fixed label Dec 9, 2023
@aleks-f aleks-f closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleks-f aleks-f

Labels
bug fixed
Projects
None yet
Milestone
Release 1.13.0
Development

No branches or pull requests
2 participants
@matejk @aleks-f