-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
nuke-web3
commented
Nov 19, 2022
- remove matrix links
- remove playground references (service reported as sun-setting)
- OSPL rule per Docs style guide
remove matrix links remove playground references (service reported as sunsetting) OSPL rule per Docs style guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor revision. Not sure about applying OSPL rule here because everything gets treated with cargo fmt
anyways AFAIK.
cargo doesn't have anything that touches .md files - so no it will not be formatted otherwise AFAIK |
Co-authored-by: Sacha Lansky <sacha@parity.io>
@sacha-l @lisa-parity @al3mart @jeluard - this should be ready now for review & merge, so we can act on https://github.com/substrate-developer-hub/substrate-node-template/issues/396 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestions
Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com>
Thank you very much @lisa-parity for the suggestions! 🤩 Merged them in now. I think we are OK to merge, please approve? |
|
||
Then run the following command to start a single node development chain. | ||
|
||
```bash | ||
```sh | ||
./scripts/docker_run.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if i run clone the substrate repo, and check out this branch 'ds/template-readme', and then as root user i run ./bin/node-template/scripts/docker_run.sh
it outputs -bash: ./bin/node-template/scripts/docker_run.sh: Permission denied
. if i run
the following first chmod +x ./bin/node-template/scripts/docker_run.sh
then i'm able to run that script.
if i then run git ls-tree -r HEAD
, it outputs the following 100644 blob 0bac44b4cfb3b61959bc65ae6de72c22fade7ff4 bin/node-template/scripts/docker_run.sh
.
so to change its permissions to 755 i think we should run chmod +x ./bin/node-template/scripts/docker_run.sh
and then commit that change to this PR?
Should work for you now (if you try again by undoing the chmod +x). Can you check @ltfschoen ? 🙏🏻 |
bot rebase |
Rebased |
@sacha-l @jeluard - review and approve? @ltfschoen #13039 can come later, and thus is ok by you? Please approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to wait until I had time to actually read through all of this with focus. These changes improve the clarity and readability, to me, so FWIW, I approve of them.
bot merge |
Error: Statuses failed for 60038cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock.
bot merge |
Error: Statuses failed for 60038cc |
bot rebase |
Rebased |
bot merge |
* update README remove matrix links remove playground references (service reported as sunsetting) OSPL rule per Docs style guide * Apply suggestions from code review Co-authored-by: Sacha Lansky <sacha@parity.io> * Update README.md * Apply suggestions from code review Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com> * (fix) chmod +x script --------- Co-authored-by: Sacha Lansky <sacha@parity.io> Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com> Co-authored-by: parity-processbot <>
* update README remove matrix links remove playground references (service reported as sunsetting) OSPL rule per Docs style guide * Apply suggestions from code review Co-authored-by: Sacha Lansky <sacha@parity.io> * Update README.md * Apply suggestions from code review Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com> * (fix) chmod +x script --------- Co-authored-by: Sacha Lansky <sacha@parity.io> Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com> Co-authored-by: parity-processbot <>
* update README remove matrix links remove playground references (service reported as sunsetting) OSPL rule per Docs style guide * Apply suggestions from code review Co-authored-by: Sacha Lansky <sacha@parity.io> * Update README.md * Apply suggestions from code review Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com> * (fix) chmod +x script --------- Co-authored-by: Sacha Lansky <sacha@parity.io> Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com> Co-authored-by: parity-processbot <>
* update README remove matrix links remove playground references (service reported as sunsetting) OSPL rule per Docs style guide * Apply suggestions from code review Co-authored-by: Sacha Lansky <sacha@parity.io> * Update README.md * Apply suggestions from code review Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com> * (fix) chmod +x script --------- Co-authored-by: Sacha Lansky <sacha@parity.io> Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com> Co-authored-by: parity-processbot <>
* update README remove matrix links remove playground references (service reported as sunsetting) OSPL rule per Docs style guide * Apply suggestions from code review Co-authored-by: Sacha Lansky <sacha@parity.io> * Update README.md * Apply suggestions from code review Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com> * (fix) chmod +x script --------- Co-authored-by: Sacha Lansky <sacha@parity.io> Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com> Co-authored-by: parity-processbot <>