Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close this repo to PRs #396

Open
1 task
nuke-web3 opened this issue Nov 19, 2022 · 5 comments
Open
1 task

Close this repo to PRs #396

nuke-web3 opened this issue Nov 19, 2022 · 5 comments

Comments

@nuke-web3
Copy link
Contributor

nuke-web3 commented Nov 19, 2022

The issue templates (hosted here https://github.com/substrate-developer-hub/substrate-node-template/issues/new/choose ) don't allow for new issues to be created, and guide people to the right place to raise issues and ask questions... but PRs can still be made.
I suggest we disable PRs here to anyone but the CI and the maintainers/owners of the repo.

All issues and PRs should be upstream only.

  • disable dependabot
@ltfschoen
Copy link
Contributor

ltfschoen commented Dec 12, 2022

Maybe mention in the README that this repo is the same as https://github.com/paritytech/substrate/tree/master/bin/node-template, so if users want to report issues or create a PR then they should do it at https://github.com/paritytech/substrate instead so new users don't get confused?

@nuke-web3
Copy link
Contributor Author

nuke-web3 commented Dec 12, 2022

this is the case already.
edit: it should be in this PR https://github.com/paritytech/substrate/pull/12741/files

@ltfschoen
Copy link
Contributor

ltfschoen commented Mar 22, 2023

@nukemandan I think we should remove all Docker related files from this repository and update this repos README to divert a users to to the Substrate repos Docker instructions https://github.com/paritytech/substrate#getting-started, I would you accept such a PR? I think @bkchr would be in favour of that?

Otherwise If suggest a simple PR that just adds a .local/ folder into the source code of this PR to resolve this legacy error that others are also experiencing https://substrate.stackexchange.com/questions/7745/error-while-running-substrate-node-template/7746#7746.

@nuke-web3
Copy link
Contributor Author

paritytech/substrate#13437 seems to address the needs upstrea IIUC, right?

I am very happy to have a PR here that isn't captured upstream that is unique to the template to fix for sure.

@ltfschoen
Copy link
Contributor

paritytech/substrate#13437 seems to address the needs upstrea IIUC, right?

I am very happy to have a PR here that isn't captured upstream that is unique to the template to fix for sure.

yes that's the one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants