-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: Update primary Substrate Docker instructions. Remove and redirect legacy erroneous substrate-node-template Docker instructions #13437
feat: Update primary Substrate Docker instructions. Remove and redirect legacy erroneous substrate-node-template Docker instructions #13437
Conversation
I'm on a slow machine so it'll take a while to test before I create the PR. Additional changes that could be made but are excluded from this PR are:
I made an attempt at trying to get this to work in this commit 69de77d#diff-5ec7001467db95278ca884bf1446c5c3138d23ffd1a2938ac92adfe6c57cef51R39, but even though i build the image with changes in the 2nd build like updating the ssl ca certificates, installing relevant linker programs for rustc and substrate, installing rustup and only giving the substrate user permissions, and updating
without updating the ssl ca certificates in the container i'd get error like:
and sometimes when i'd run
|
bin/node-template/Cargo.toml
Outdated
@@ -0,0 +1,8 @@ | |||
[workspace] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've removed that file now.
i checked it still builds successfully when i ran the following on ubuntu 22.04 LTS after removing that file:
cd bin/node-template && \
curl --proto '=https' --tlsv1.3 https://sh.rustup.rs -sSf | sh -s -- -y && \
. $HOME/.cargo/env && \
sudo apt install -y build-essential libclang-dev protobuf-compiler && \
rustup update nightly && \
rustup target add wasm32-unknown-unknown --toolchain nightly && \
cargo build --release
@ltfschoen please merge master |
i've merged latest master and fixed conflicts |
@ltfschoen thanks for contributing! |
Description:
docker compose
v2 anddocker-compose
v1.docker
(notdocker-compose
ordocker compose
), so we don't have that Docker Compose versioning issue anymore.mkdir ./.local
before running the script./scripts/docker_run.sh
to avoid getting the error `Error response from daemon: invalid mount config for type "bind": bind source path does not exist: ~/substrate/bin/node-template/.local. That PR was closed in favour of encouraging users to instead use the Substrate docker instructions in https://github.com/paritytech/substrate/blob/master/docker/README.md so they use https://github.com/paritytech/substrate/blob/master/docker/substrate_builder.Dockerfile, and just tweak those instructions to use the node-template part of it, which makes the most sense. This change would go hand-in-hand with this PR fix: Fixes #13071 change order of ldd command and update ./docker/README.md #13072 that fixes a minor issue with the Substrate Dockerfile and updates the instructions.Related Issues: You mentioned a related issue if this PR is related to it, e.g.
Fixes #228
orRelated #1337
.2 Reviewers: You asked at least two reviewers to review. If you aren't sure, start with GH suggestions.
Style Guide: Your PR adheres to the style guide
N/A [X] Runtime Version: You bumped the runtime version if there are breaking changes in the runtime.
N/A [X] Docs: You updated any rustdocs which may need to change.
N/A [X] Polkadot Companion: Has the PR altered the external API or interfaces used by Polkadot?