-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CLI commands w/ and w/o project #910
Refactor CLI commands w/ and w/o project #910
Conversation
- "datum describe-downloads" -> "datum download describe" - "datum download" -> "datum download get" - Refactor datum download cli test to use pytest framework Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #910 +/- ##
===========================================
- Coverage 78.88% 78.87% -0.01%
===========================================
Files 210 215 +5
Lines 25065 25120 +55
Branches 5032 5039 +7
===========================================
+ Hits 19773 19814 +41
- Misses 4159 4173 +14
Partials 1133 1133
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
- datumaro/cli/commands <- do not require a project - datumaro/cli/commands/require_project <- require a project Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
It's ready. Please review this PR. |
- Ticket no. 108466 - While working on #949, I realized that several commands grouped by `dataset operations` in `datum project` are actually project free commands (previously changed in #910). - So, I decided to move them outside of `datum project` again. - Aligning in terms of documentation to these changes will be made in the next PR. Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Summary
To-be (w/o project)
To-be (w/ project)
As-is
How to test
This change will be covered by the modified
integration/cli
tests.Checklist
License
Feel free to contact the maintainers if that's a concern.