Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move project free commands to outside again #952

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Apr 19, 2023

Summary

Before datum project

usage: datum project [-h]

Manipulate projects.

By default, the project to be operated on is searched for in the current directory. An additional '-p' argument can be passed to specify project location.

optional arguments:
  -h, --help  show this help message and exit

Project modification:
  add                  Add dataset
  create               Create empty project
  import               Import dataset
  remove               Remove dataset
Project versioning:  
  checkout             Switch to another branch or revision
  commit               Commit changes in tracked files
  log                  List history
  status               Display current status
  pinfo                Print project info
Dataset operations:  
  diff                 Compare datasets
  export               Export dataset in some format
  stats                Compute dataset statistics
  transform            Modify dataset items
  validate             Validate dataset
  dinfo                Print dataset info

Run 'datum project COMMAND --help' for more information on a command.:

After datum project: Remove "dataset operations" group

usage: datum project [-h]

Manipulate projects.

By default, the project to be operated on is searched for in the current directory. An additional '-p' argument can be passed to specify project location.

optional arguments:
  -h, --help  show this help message and exit

Project modification:
  add                  Add dataset
  create               Create empty project
  export               Export dataset in some format
  import               Import dataset
  remove               Remove dataset
Project versioning:  
  checkout             Switch to another branch or revision
  commit               Commit changes in tracked files
  log                  List history
  info                 Print project information
  status               Display current branch and revision status

Run 'datum project COMMAND --help' for more information on a command.:

Before datum

usage: datum [-h] [--version] [--loglevel LOGLEVEL]

Dataset Framework

optional arguments:
  -h, --help           show this help message and exit
  --version            show program's version number and exit
  --loglevel LOGLEVEL  Logging level (options: debug, info, warning, error, critical; default: info)

Contexts:
  model                Actions with models
  project              Actions with projects
  source               Actions with data sources
  util                 Auxillary tools and utilities

Basic Commands:
  convert              Convert dataset between formats
  detect               Detect the format of a dataset
  download             Download a publicly available dataset
  explain              Run Explainable AI algorithm for model
  filter               Filter dataset items
  generate             Generate synthetic dataset
  merge                Merge datasets
  patch                Update dataset from another one
  search               Search similar datasetitems of query

Run 'datum COMMAND --help' for more information on a command.:

After datum: Move commands in the "dataset operations" group

usage: datum [-h] [--version] [--loglevel LOGLEVEL]

Dataset Framework

optional arguments:
  -h, --help           show this help message and exit
  --version            show program's version number and exit
  --loglevel LOGLEVEL  Logging level (options: debug, info, warning, error, critical; default: info)

Contexts:
  model                Actions with models
  project              Actions with projects
  source               Actions with data sources
  util                 Auxillary tools and utilities

Basic Commands:
  convert              Convert dataset between formats
  detect               Detect the format of a dataset
  diff                 Compare datasets
  dinfo                Print dataset info
  download             Download a publicly available dataset
  explain              Run Explainable AI algorithm for model
  filter               Filter dataset items
  generate             Generate synthetic dataset
  merge                Merge datasets
  patch                Update dataset from another one
  search               Search similar datasetitems of query
  stats                Compute dataset statistics
  transform            Modify dataset items
  validate             Validate dataset

How to test

I corrected the existing tests for this change.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review April 19, 2023 02:10
@vinnamkim vinnamkim requested review from a team as code owners April 19, 2023 02:10
@vinnamkim vinnamkim added this to the 1.2.0 milestone Apr 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Patch coverage: 73.91% and project coverage change: -0.01 ⚠️

Comparison is base (5d872d2) 78.70% compared to head (9861d51) 78.70%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.2.0     #952      +/-   ##
==================================================
- Coverage           78.70%   78.70%   -0.01%     
==================================================
  Files                 232      231       -1     
  Lines               26420    26419       -1     
  Branches             5258     5258              
==================================================
- Hits                20795    20794       -1     
  Misses               4400     4400              
  Partials             1225     1225              
Flag Coverage Δ
macos-11_Python-3.8 77.73% <73.91%> (-0.01%) ⬇️
ubuntu-20.04_Python-3.8 78.68% <73.91%> (-0.01%) ⬇️
windows-2019_Python-3.8 78.59% <73.91%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...li/commands/require_project/modification/export.py 23.94% <ø> (ø)
datumaro/util/telemetry_utils.py 45.83% <0.00%> (ø)
datumaro/cli/commands/__init__.py 80.00% <100.00%> (ø)
datumaro/cli/commands/diff.py 20.95% <100.00%> (ø)
datumaro/cli/commands/info.py 17.24% <100.00%> (ø)
datumaro/cli/commands/require_project/__init__.py 66.66% <100.00%> (ø)
.../commands/require_project/modification/__init__.py 100.00% <100.00%> (ø)
datumaro/cli/commands/stats.py 31.70% <100.00%> (ø)
datumaro/cli/commands/transform.py 19.04% <100.00%> (ø)
datumaro/cli/commands/validate.py 19.17% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim changed the base branch from develop to releases/1.2.0 April 19, 2023 02:35
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinnamkim vinnamkim merged commit e152dbd into openvinotoolkit:releases/1.2.0 Apr 19, 2023
@vinnamkim vinnamkim deleted the refactor/move-again-project-free-command-to-outside branch April 19, 2023 05:54
@vinnamkim vinnamkim mentioned this pull request Apr 19, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants