-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor download CLI command #909
Refactor download CLI command #909
Conversation
- "datum describe-downloads" -> "datum download describe" - "datum download" -> "datum download get" - Refactor datum download cli test to use pytest framework Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #909 +/- ##
===========================================
- Coverage 78.90% 78.88% -0.03%
===========================================
Files 211 210 -1
Lines 25059 25065 +6
Branches 5031 5032 +1
===========================================
- Hits 19774 19773 -1
- Misses 4152 4159 +7
Partials 1133 1133
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me. But I am not sure whether no_project
is appropriate or not. It could be related to which commands are more general and preferable to users between w/ project or wo/ project. If wo/ project is more general, it would be good to move them in an independent directory. What do you think?
It will be re-refactored in #910 again. We can continue this discussion in that PR. |
Summary
How to test
I refactor the CLI test for this change as well.
Checklist
License
Feel free to contact the maintainers if that's a concern.