Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor download CLI command #909

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Apr 3, 2023

Summary

  • Move "datum describe-downloads" -> "datum download describe"
  • Move "datum download" -> "datum download get"
  • Refactor datum download cli test to use pytest framework
  • Ticket no. 107277

How to test

I refactor the CLI test for this change as well.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

 - "datum describe-downloads" -> "datum download describe"
 - "datum download" -> "datum download get"
 - Refactor datum download cli test to use pytest framework

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review April 3, 2023 07:28
@vinnamkim vinnamkim requested review from a team as code owners April 3, 2023 07:28
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Patch coverage: 18.64% and project coverage change: -0.03 ⚠️

Comparison is base (8270e64) 78.90% compared to head (4f07d02) 78.88%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #909      +/-   ##
===========================================
- Coverage    78.90%   78.88%   -0.03%     
===========================================
  Files          211      210       -1     
  Lines        25059    25065       +6     
  Branches      5031     5032       +1     
===========================================
- Hits         19774    19773       -1     
- Misses        4152     4159       +7     
  Partials      1133     1133              
Flag Coverage Δ
macos-11_Python-3.8 77.87% <18.64%> (-0.03%) ⬇️
ubuntu-20.04_Python-3.8 78.87% <18.64%> (-0.03%) ⬇️
windows-2019_Python-3.8 78.82% <18.64%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/cli/__main__.py 0.00% <ø> (ø)
datumaro/cli/commands/no_project/download.py 17.85% <17.85%> (ø)
datumaro/cli/util/__init__.py 28.30% <20.00%> (-0.87%) ⬇️
datumaro/cli/commands/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim added this to the 1.2.0 milestone Apr 3, 2023
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me. But I am not sure whether no_project is appropriate or not. It could be related to which commands are more general and preferable to users between w/ project or wo/ project. If wo/ project is more general, it would be good to move them in an independent directory. What do you think?

@vinnamkim
Copy link
Contributor Author

Overall it looks good to me. But I am not sure whether no_project is appropriate or not. It could be related to which commands are more general and preferable to users between w/ project or wo/ project. If wo/ project is more general, it would be good to move them in an independent directory. What do you think?

It will be re-refactored in #910 again. We can continue this discussion in that PR.

@vinnamkim vinnamkim merged commit 3e0cbf0 into openvinotoolkit:develop Apr 5, 2023
@vinnamkim vinnamkim deleted the feature/aggregate branch April 5, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants