Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video input support #521

Merged
merged 41 commits into from
Nov 30, 2021
Merged

Video input support #521

merged 41 commits into from
Nov 30, 2021

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Oct 18, 2021 •
edited
Loading

Summary

Related #129

  • Added video reading API
  • Added tests using pytest

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

This was linked to issues Nov 15, 2021
Support video import #129
Closed
Importing a video-based datasets #456
Closed
This was unlinked from issues Nov 17, 2021
Support video import #129
Closed
Importing a video-based datasets #456
Closed
@zhiltsov-max zhiltsov-max changed the title [WIP] Video input support Video input support Nov 17, 2021
@zhiltsov-max zhiltsov-max mentioned this pull request Nov 18, 2021
Merged
10 tasks
IRDonch
IRDonch reviewed Nov 22, 2021
View reviewed changes
datumaro/components/media.py Outdated Show resolved Hide resolved
datumaro/components/media.py Outdated Show resolved Hide resolved
datumaro/components/media.py Outdated Show resolved Hide resolved
datumaro/components/media.py Outdated Show resolved Hide resolved
IRDonch
IRDonch reviewed Nov 22, 2021
View reviewed changes
datumaro/components/media.py Outdated Show resolved Hide resolved
datumaro/components/media.py Outdated Show resolved Hide resolved
datumaro/components/media.py Outdated Show resolved Hide resolved
datumaro/components/media.py Outdated Show resolved Hide resolved
IRDonch
IRDonch reviewed Nov 23, 2021
View reviewed changes
datumaro/util/image.py Outdated Show resolved Hide resolved
tests/test_video.py Outdated Show resolved Hide resolved
tests/test_video.py Outdated Show resolved Hide resolved
tests/test_video.py Outdated Show resolved Hide resolved
tests/test_video.py Outdated Show resolved Hide resolved
tests/test_video.py Outdated Show resolved Hide resolved
tests/test_video.py Outdated Show resolved Hide resolved
@IRDonch
Copy link

IRDonch commented Nov 23, 2021

FWIW, the refactoring changes that are in this PR could easily be submitted as a separate PR, which would make it easier to review.

Apply suggestions from code review
7ce1d6d 
Co-authored-by: Roman Donchenko <roman.donchenko@intel.com>
@zhiltsov-max zhiltsov-max changed the title Video input support [WIP] Video input support Nov 23, 2021
@zhiltsov-max zhiltsov-max changed the title [WIP] Video input support Video input support Nov 25, 2021
@IRDonch IRDonch mentioned this pull request Nov 26, 2021
Merged
7 tasks
@IRDonch IRDonch merged commit 0b7c3fa into develop Nov 30, 2021
@IRDonch IRDonch deleted the zm/video-support branch November 30, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IRDonch IRDonch IRDonch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhiltsov-max @IRDonch