Remove the Image
<->np.ndarray
equality comparison support
#568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This support has some questionable semantics:
It's not symmetric (
Image
can be equal tondarray
, but not the other way around).It doesn't behave the same as
ndarray
comparison (which returns anndarray
rather thanbool
), so it's not quite transitive either (ifimage == array1
andimage == array2
are true, thenarray1 == array2
is not true (but an array ofTrue
s).Moreover, it's seemingly only used in two tests, and those tests can easily use
np.testing.assert_array_equal
instead, which has the added benefit of printing detailed mismatch information.Inspired by the discussion in #521.
How to test
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.