-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add video frames extractor and split_video command #555
Conversation
datumaro/components/media_manager.py
Outdated
def push(self, key, media): | ||
if self.capacity <= len(self.items): | ||
self.items.popitem(last=True) | ||
self.items[key] = media |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why here is no required to close item that was removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it needs. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Splits a video into separate frames and saves them in a directory. | ||
After the splitting, the images can be added into a project using | ||
the [`import` command](./sources/#source-import) and the `image_dir` format. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that split_video
-> image_dir
and video_frames
that two alternative approaches to import video dataset.
Maybe it will be useful to add import argument --subset
for image_dir
format to make these approaches fully alternative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The both have this parameter. Do you mean, in CLI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I mean in CLI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
b76916a
to
5c2b9d4
Compare
Summary
datum util split_video
command to split videoMediaManager
class (TBD: removeImageCache
)datum import
video_frames
source produces a warning about unstable resultsadd
,import
andexport
without a projectmake_dataset
on empty project tree now properly produces the errorimage_dir
format extractor:--subset
CLI parameterexts
anddepth
parametersTBD / Problems:
Project
How to test
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.