Add TestReleaseNotesCheck.groovy #2765
Conversation
Signed-off-by: Jeff Lu <chunglu@amazon.com>
jordarlu
added
the
technical-debt
| public void testReleaseNoteCheckPipeline() { | ||
| super.testPipeline("jenkins/release-notes-check/release-notes-check.jenkinsfile", | ||
| "tests/jenkins/jenkinsjob-regression-files/release-notes-check/release-notes-check.jenkinsfile") | ||
| } |
There was a problem hiding this comment.
I believe we would like to assert few things like if the intended shell script has the expected calls. In future if the library makes some changes, we would like to catch that in our tests.
There was a problem hiding this comment.
@gaiksaya , makes sense.. I was thinking that as well, but debating with myself that the regression txt has the shared lib covered as well..
I also think it is better we do that you said .. I will add test to check if certain script/lib is called..
thanks!!
Signed-off-by: Jeff Lu <chunglu@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #2765 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 157 157
Lines 4242 4242
=======================================
Hits 3994 3994
Misses 248 248 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks for the approval, @gaiksaya |
* Add TestReleaseNotesCheck.groovy Signed-off-by: Jeff Lu <chunglu@amazon.com> * add additional test to verify if the needed sh script in place Signed-off-by: Jeff Lu <chunglu@amazon.com> Signed-off-by: Jeff Lu <chunglu@amazon.com> Signed-off-by: Monu Singh <msnghgw@amazon.com>
Signed-off-by: Jeff Lu chunglu@amazon.com
Description
Describe what this change achieves.
As part of the effort on META #1468 , we are adding missing test job for jenkinsfile(s).
Particularly, this PR is created to address missing test job for release-notes-check.jenkinsfile [https://github.com/opensearch-project/opensearch-build/tree/main/jenkins/release-notes-check]
Issues Resolved
#2713 as part of #1468
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.