Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Add tests for existing jenkins jobs #1468

Open
1 of 12 tasks
abhinavGupta16 opened this issue Jan 13, 2022 · 9 comments
Open
1 of 12 tasks

[META] Add tests for existing jenkins jobs #1468

abhinavGupta16 opened this issue Jan 13, 2022 · 9 comments
Assignees
Labels
enhancement New Enhancement Meta technical-debt Additional rework required to improve the existing code

Comments

@abhinavGupta16
Copy link
Contributor

abhinavGupta16 commented Jan 13, 2022

Is your feature request related to a problem? Please describe

Following up on the comment - #1444 (comment)

The existing jenkins jobs needs tests -

Describe the solution you'd like

Every job should have a test associated with it, with a regression txt file inside jenkinsjob-regression-files

Acceptance Criteria

  • All the libraries should have a lib tester associated with it
  • All the jenkins job should have a test associated with it that uses only lib testers for libraries
  • A check is added in CI making sure every job has a test
@abhinavGupta16 abhinavGupta16 added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Jan 13, 2022
@abhinavGupta16
Copy link
Contributor Author

abhinavGupta16 commented Jan 13, 2022

Let's create an issue for every task here when the work is begun. Thank you!

@abhinavGupta16 abhinavGupta16 added the good first issue Good for newcomers label Jan 14, 2022
@dblock
Copy link
Member

dblock commented Jan 14, 2022

Let's create an issue for every task here when the work is begun. Thank you!

FWIW we have a lot of 1-line issues, I think it's totally fine to track a list like here, link to PRs as we go, then close the issue when we have 100% done

@gaiksaya gaiksaya added Meta and removed untriaged Issues that have not yet been triaged labels Jan 25, 2022
@abhinavGupta16 abhinavGupta16 changed the title [META] Add tests for existing jenkins file [META] Add tests for existing jenkins jobs Jan 25, 2022
@abhinavGupta16 abhinavGupta16 added the technical-debt Additional rework required to improve the existing code label Jan 31, 2022
@prudhvigodithi
Copy link
Collaborator

The tests already exists for all shared libraries used by Jenkinsfiles, the functions are being fully tested.
Closing this issue, please feel free to reopen.
https://github.com/opensearch-project/opensearch-build/tree/main/tests/jenkins

@gaiksaya
Copy link
Member

gaiksaya commented Aug 30, 2022

These tests for jenkinsFiles and not the libraries. We need to add tests for the existing jenkinsFile in this repo. Might need to revisit the list mentioned in description.
Once the libraries are separated, we need to add tests to check the compatibility and expected assertions in these tests.

Just to explain:
There are 2 types of tests that exists in build repo today.

  1. Tests that test the jenkins library (vars folder)
  2. Tests that actually test the jenkins pipelines.
    We have mixed those up in few libraries which is incorrect. Hence need this issue to rectify it.

Example: https://github.com/opensearch-project/opensearch-build/blob/main/tests/jenkins/TestCCRPerfTest.groovy#L73-L109

@jordarlu
Copy link
Contributor

jordarlu commented Sep 9, 2022

Hi, updating the To-Do list/table to show which Test we should be working on...

  Jenkins job location Test groovy (tests/jenkins/)
1 bwc-test.jenkinsfile opensearch-build/jenkins/opensearch-dashboards/ TestOpenSearchDashboardsBwcTest.groovy
2 distribution-build.jenkinsfile opensearch-build/jenkins/opensearch-dashboards/  
3 integ-test.jenkinsfile opensearch-build/jenkins/opensearch-dashboards/ TestOpenSearchDashboardsIntegTest.groovy
4 bwc-test.jenkinsfile opensearch-build/jenkins/opensearch/ TestOpenSearchBwcTest.groovy
5 distribution-build.jenkinsfile opensearch-build/jenkins/opensearch/  
6 integ-test.jenkinsfile opensearch-build/jenkins/opensearch/ TestOpenSearchIntegTest.groovy
7 perf-test.jenkinsfile opensearch-build/jenkins/opensearch/ TestRunNonSecurityPerfTestScript.groovy
8 maven-sign-release.jenkinsfile opensearch-build/jenkins/opensearch-maven-release/ TestMavenSignReleaseJob.groovy
9 opensearch-ruby.jenkinsfile opensearch-build/jenkins/opensearch-ruby/  
10 promote-artifacts.jenkinsfile opensearch-build/jenkins/promotion/  
11 promote-docker-ecr.jenkinsfile opensearch-build/jenkins/promotion/ TestPromoteContainer.groovy
12 promote-yum-repos.jenkinsfile opensearch-build/jenkins/promotion/  
13 release-notes-check.jenkinsfile opensearch-build/jenkins/release-notes-check/  
14 release-tag.jenkinsfile opensearch-build/jenkins/release-tag/  
15 rpm-validation.jenkinsfile opensearch-build/jenkins/rpm-validation/  
16 sign-standalone-artifacts.jenkinsfile opensearch-build/jenkins/sign-artifacts/ TestSignStandaloneArtifactsJob.groovy
17 whitesource-scan.jenkinsfile opensearch-build/jenkins/vulnerability-scan/  
18 perf-test.jenkinsfile opensearch-build/jenkins/cross-cluster-replication/ TestCCRPerfTest.groovy
19 release-data-prepper-all-artifacts.jenkinsfile opensearch-build/jenkins/data-prepper/ TestDataPrepperReleaseArtifacts.groovy
20 docker-build.jenkinsfile opensearch-build/jenkins/docker/  
21 docker-copy.jenkinsfile opensearch-build/jenkins/docker/  
22 gradle-check.jenkinsfile opensearch-build/jenkins/gradle/  
23 check-for-build.jenkinsfile opensearch-build/jenkins/  

@bbarani bbarani added hacktoberfest Global event that encourages people to contribute to open-source. and removed good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source. labels Oct 5, 2022
@jordarlu
Copy link
Contributor

Hi, Adding #2713 and #2714 to address test job for release-notes-check jenkinsfile. Thanks.

@jordarlu
Copy link
Contributor

Hi, Adding #2722 and #2723 to address test job for whitesource-scan jenkinsfile. Thanks.

@jordarlu
Copy link
Contributor

Hi, Adding #2789 and #2790 to addess test job for docker-build.jenkinsfile. thanks.

@jordarlu
Copy link
Contributor

Hi, Adding #2791 and #2792 to addess test job for docker-build.jenkinsfile. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement Meta technical-debt Additional rework required to improve the existing code
Projects
None yet
Development

No branches or pull requests

6 participants