Change min oversample to 1 #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
jmazanec15
added
Bug Fixes
navneet1v
reviewed
Sep 18, 2024
| @@ -18,7 +18,7 @@ public final class RescoreContext { | |||
|
|
|||
| public static final float DEFAULT_OVERSAMPLE_FACTOR = 1.0f; | |||
| public static final float MAX_OVERSAMPLE_FACTOR = 100.0f; | |||
| public static final float MIN_OVERSAMPLE_FACTOR = 0.0f; | |||
| public static final float MIN_OVERSAMPLE_FACTOR = 1.0f; | |||
There was a problem hiding this comment.
[Question] should we have a UT validating this?
There was a problem hiding this comment.
navneet1v
approved these changes
Sep 18, 2024
ryanbogan
approved these changes
Sep 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit e3cf814)
ryanbogan
pushed a commit
that referenced
this pull request
Sep 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit e3cf814)
navneet1v
pushed a commit
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes minimum oversample factor from 0 to 1. Having an oversample factor that will return less results than the second pass needs to return will always result in less than k results being returned. This is a bug.
From a bwc perspective, we could check if index is created on 2.17 for validation. However, given this is a bug, I think its better to document it as 1.0f and not look at index versioning.
Related Issues
#2112
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.