Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change min oversample to 1 #2117

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Change min oversample to 1 #2117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/opensearch/knn/index/query/rescore/RescoreContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public final class RescoreContext {

public static final float DEFAULT_OVERSAMPLE_FACTOR = 1.0f;
public static final float MAX_OVERSAMPLE_FACTOR = 100.0f;
public static final float MIN_OVERSAMPLE_FACTOR = 0.0f;
public static final float MIN_OVERSAMPLE_FACTOR = 1.0f;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Question] should we have a UT validating this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

  1. https://github.com/opensearch-project/k-NN/blob/main/src/test/java/org/opensearch/knn/index/query/parser/RescoreValidationTests.java#L33
  2. https://github.com/opensearch-project/k-NN/blob/main/src/test/java/org/opensearch/knn/index/query/KNNQueryBuilderInvalidParamsTests.java#L95


public static final int MAX_FIRST_PASS_RESULTS = 10000;

Expand Down
Loading