Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]The MIN_OVERSAMPLE_FACTOR is set to 0. #2112

Closed
kolchfa-aws opened this issue Sep 17, 2024 · 1 comment
Closed

[BUG]The MIN_OVERSAMPLE_FACTOR is set to 0. #2112

kolchfa-aws opened this issue Sep 17, 2024 · 1 comment
Assignees
@jmazanec15
Labels
bug Something isn't working

Comments

@kolchfa-aws
Copy link

kolchfa-aws commented Sep 17, 2024 •
edited
Loading

What is the bug?
The MIN_OVERSAMPLE_FACTOR is currently set as 0 in RescoreContext. If I understand correctly, it should be set to 1. I think setting it to 0 makes it have no effect on this formula.
@kolchfa-aws kolchfa-aws added bug Something isn't working untriaged labels Sep 17, 2024
@jmazanec15 jmazanec15 mentioned this issue Sep 18, 2024
Merged
1 task
@kkhatua
Copy link
Member

kkhatua commented Sep 20, 2024

@jmazanec15 ... why didn't the UTs catch this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmazanec15 jmazanec15

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kkhatua @jmazanec15 @naveentatikonda @kolchfa-aws