Adds support on UI for min primary shard size rollover condition and min rollover age transition condition #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Drew Baugher <dbbaughe@amazon.com>
…dition since backend supports no conditions Signed-off-by: Drew Baugher <dbbaughe@amazon.com>
…ng the create policy fail when sending to backend Signed-off-by: Drew Baugher <dbbaughe@amazon.com>
Signed-off-by: Drew Baugher <dbbaughe@amazon.com>
Signed-off-by: Drew Baugher <dbbaughe@amazon.com>
downsrob
approved these changes
Mar 8, 2022
|
Do you want to add the release notes for this in this same PR? Or I can handle it in another |
downsrob
pushed a commit
to downsrob/index-management-dashboards-plugin
that referenced
this pull request
Mar 9, 2022
…min rollover age transition condition (opensearch-project#159) * Adds the min primary shard size condition in rollover UI Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Removes validation for rollover action that requires at least one condition since backend supports no conditions Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Removes empty rollover conditions in default rollover JSON thats making the create policy fail when sending to backend Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Adds UI support for min rollover age in the transition UI Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Updates jest snapshots for create transition and create action Signed-off-by: Drew Baugher <dbbaughe@amazon.com> Signed-off-by: Robert Downs <downsrob@amazon.com>
downsrob
added a commit
that referenced
this pull request
Mar 9, 2022
* Create backport workflow (#148) * Create backport.yml Signed-off-by: Annie Lee <leeyun@amazon.com> * Create delete_backport_branch.yml Signed-off-by: Annie Lee <leeyun@amazon.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds support for creating and displaying the transform continuous mode (#153) * Adds continuous transform mode display and create Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds release note Signed-off-by: Clay Downs <89109232+downsrob@users.noreply.github.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds support on UI for min primary shard size rollover condition and min rollover age transition condition (#159) * Adds the min primary shard size condition in rollover UI Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Removes validation for rollover action that requires at least one condition since backend supports no conditions Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Removes empty rollover conditions in default rollover JSON thats making the create policy fail when sending to backend Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Adds UI support for min rollover age in the transition UI Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Updates jest snapshots for create transition and create action Signed-off-by: Drew Baugher <dbbaughe@amazon.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Add backport documentation link (#161) * Create BACKPORT.md Signed-off-by: Annie Lee <leeyun@amazon.com> * Remove backport documentation file and replace with a link Signed-off-by: Annie Lee <leeyun@amazon.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Updates release notes with new commits (#163) Signed-off-by: Robert Downs <downsrob@amazon.com> Co-authored-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> Co-authored-by: Annie Lee <leeyun@amazon.com>
bowenlan-amzn
pushed a commit
that referenced
this pull request
May 9, 2022
* Create backport workflow (#148) * Create backport.yml Signed-off-by: Annie Lee <leeyun@amazon.com> * Create delete_backport_branch.yml Signed-off-by: Annie Lee <leeyun@amazon.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds support for creating and displaying the transform continuous mode (#153) * Adds continuous transform mode display and create Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds release note Signed-off-by: Clay Downs <89109232+downsrob@users.noreply.github.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds support on UI for min primary shard size rollover condition and min rollover age transition condition (#159) * Adds the min primary shard size condition in rollover UI Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Removes validation for rollover action that requires at least one condition since backend supports no conditions Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Removes empty rollover conditions in default rollover JSON thats making the create policy fail when sending to backend Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Adds UI support for min rollover age in the transition UI Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Updates jest snapshots for create transition and create action Signed-off-by: Drew Baugher <dbbaughe@amazon.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Add backport documentation link (#161) * Create BACKPORT.md Signed-off-by: Annie Lee <leeyun@amazon.com> * Remove backport documentation file and replace with a link Signed-off-by: Annie Lee <leeyun@amazon.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Updates release notes with new commits (#163) Signed-off-by: Robert Downs <downsrob@amazon.com> Co-authored-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> Co-authored-by: Annie Lee <leeyun@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support on UI for min primary shard size rollover condition and min rollover age transition condition
Updates jest snapshot tests
Removes validation for rollover action that was requiring on the UI at least one condition since backend supports no conditions.
Removes the empty rollover conditions in the default rollover action as it was causing it to be sent to backend which was then failing.
Backend PRs:
opensearch-project/index-management#220
opensearch-project/index-management#215
Seems like the visual part just has jest snapshot tests w/ and not functional tests. I see we have this issue to add some cypress ones, but would also be good to have some functional jest tests too. Will rename the issue to cover both test types and pick it up separately as it's going to be a longer item.
Issues Resolved
#158
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.