-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds min rollover age as a transition condition #215
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #215 +/- ##
============================================
+ Coverage 75.73% 76.13% +0.40%
- Complexity 1927 1950 +23
============================================
Files 260 260
Lines 11094 11122 +28
Branches 1746 1753 +7
============================================
+ Hits 8402 8468 +66
+ Misses 1747 1697 -50
- Partials 945 957 +12
Continue to review full report at Codecov.
|
Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
thalurur
approved these changes
Dec 7, 2021
downsrob
reviewed
Dec 7, 2021
src/main/kotlin/org/opensearch/indexmanagement/indexstatemanagement/model/Transition.kt
Show resolved
Hide resolved
downsrob
approved these changes
Dec 7, 2021
1 task
downsrob
pushed a commit
to downsrob/index-management
that referenced
this pull request
Mar 9, 2022
* Adds min rollover age as a transition condition Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes link checker Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
downsrob
pushed a commit
to downsrob/index-management
that referenced
this pull request
Mar 9, 2022
* Adds min rollover age as a transition condition Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes link checker Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> Signed-off-by: Robert Downs <downsrob@amazon.com>
downsrob
pushed a commit
that referenced
this pull request
Mar 9, 2022
* Adds min rollover age as a transition condition Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes link checker Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> Signed-off-by: Robert Downs <downsrob@amazon.com>
4 tasks
wuychn
pushed a commit
to ochprince/index-management
that referenced
this pull request
Mar 16, 2023
* Adds min rollover age as a transition condition Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes link checker Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Drew Baugher 46505179+dbbaughe@users.noreply.github.com
Issue #, if available:
#191
Description of changes:
Adds a new transition condition - min_rollover_age
This lets you transition to a new state based on when the index was rolled over instead of the index creation date to help with keeping data around for a specific amount of time.
As an index can be rolled over multiple times using different aliases (which is uncommon, i.e. I haven't actually seen that use case yet, so if you have this use case please comment on the PR) we will use the oldest rollover date that is available, i.e. the first one that happened. In the future if it seems like users want to specify which alias to use for this calculation we can introduce an index level setting to allow specifying the exact alias to use. I didn't include it for now in this PR as it seems like an unknown use case and we're starting to have a lot of settings introduced so want to limit them.
If the index evaluates this condition and the index was never rolled over, we will fail as this transition condition is only meant to be used after a rollover action has occured.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.