Add backport documentation link #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Annie Lee <leeyun@amazon.com>
annie3431
added
backport 1.x
documentation
Codecov Report
@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 63.38% 63.40% +0.01%
==========================================
Files 155 155
Lines 4419 4432 +13
Branches 690 691 +1
==========================================
+ Hits 2801 2810 +9
- Misses 1402 1407 +5
+ Partials 216 215 -1
Continue to review full report at Codecov.
|
dbbaughe
reviewed
Mar 8, 2022
BACKPORT.md
Outdated
| 2. The backport workflow is now created by a Github App called `opensearch-trigger-bot` instead of `github-actions` which allows CI to run on such PRs. | ||
| 3. The backport branches are named in the form `backport/backport-<original PR number>-to-<base>`. These branches will be cleaned up by an auto delete workflow once the backport PR is merged. | ||
|
|
||
| ### Integration |
There was a problem hiding this comment.
This seems odd to include this no? I would assume we would just want documentation on how to utilize the backporting mechanism with a link/reference to this equivalent doc in the opensearch plugins repository.
There was a problem hiding this comment.
Yeah I think this can be changed to a link in developer_guide or README file
Signed-off-by: Annie Lee <leeyun@amazon.com>
dbbaughe
approved these changes
Mar 9, 2022
bowenlan-amzn
approved these changes
Mar 9, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
* Create BACKPORT.md Signed-off-by: Annie Lee <leeyun@amazon.com> * Remove backport documentation file and replace with a link Signed-off-by: Annie Lee <leeyun@amazon.com> (cherry picked from commit f69b5fe)
downsrob
pushed a commit
to downsrob/index-management-dashboards-plugin
that referenced
this pull request
Mar 9, 2022
* Create BACKPORT.md Signed-off-by: Annie Lee <leeyun@amazon.com> * Remove backport documentation file and replace with a link Signed-off-by: Annie Lee <leeyun@amazon.com> Signed-off-by: Robert Downs <downsrob@amazon.com>
downsrob
added a commit
that referenced
this pull request
Mar 9, 2022
* Create backport workflow (#148) * Create backport.yml Signed-off-by: Annie Lee <leeyun@amazon.com> * Create delete_backport_branch.yml Signed-off-by: Annie Lee <leeyun@amazon.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds support for creating and displaying the transform continuous mode (#153) * Adds continuous transform mode display and create Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds release note Signed-off-by: Clay Downs <89109232+downsrob@users.noreply.github.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds support on UI for min primary shard size rollover condition and min rollover age transition condition (#159) * Adds the min primary shard size condition in rollover UI Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Removes validation for rollover action that requires at least one condition since backend supports no conditions Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Removes empty rollover conditions in default rollover JSON thats making the create policy fail when sending to backend Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Adds UI support for min rollover age in the transition UI Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Updates jest snapshots for create transition and create action Signed-off-by: Drew Baugher <dbbaughe@amazon.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Add backport documentation link (#161) * Create BACKPORT.md Signed-off-by: Annie Lee <leeyun@amazon.com> * Remove backport documentation file and replace with a link Signed-off-by: Annie Lee <leeyun@amazon.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Updates release notes with new commits (#163) Signed-off-by: Robert Downs <downsrob@amazon.com> Co-authored-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> Co-authored-by: Annie Lee <leeyun@amazon.com>
bowenlan-amzn
pushed a commit
that referenced
this pull request
May 9, 2022
* Create backport workflow (#148) * Create backport.yml Signed-off-by: Annie Lee <leeyun@amazon.com> * Create delete_backport_branch.yml Signed-off-by: Annie Lee <leeyun@amazon.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds support for creating and displaying the transform continuous mode (#153) * Adds continuous transform mode display and create Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds release note Signed-off-by: Clay Downs <89109232+downsrob@users.noreply.github.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds support on UI for min primary shard size rollover condition and min rollover age transition condition (#159) * Adds the min primary shard size condition in rollover UI Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Removes validation for rollover action that requires at least one condition since backend supports no conditions Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Removes empty rollover conditions in default rollover JSON thats making the create policy fail when sending to backend Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Adds UI support for min rollover age in the transition UI Signed-off-by: Drew Baugher <dbbaughe@amazon.com> * Updates jest snapshots for create transition and create action Signed-off-by: Drew Baugher <dbbaughe@amazon.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Add backport documentation link (#161) * Create BACKPORT.md Signed-off-by: Annie Lee <leeyun@amazon.com> * Remove backport documentation file and replace with a link Signed-off-by: Annie Lee <leeyun@amazon.com> Signed-off-by: Robert Downs <downsrob@amazon.com> * Updates release notes with new commits (#163) Signed-off-by: Robert Downs <downsrob@amazon.com> Co-authored-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> Co-authored-by: Annie Lee <leeyun@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Annie Lee leeyun@amazon.com
Description
Add the backport workflow documentation
Issues Resolved
#135
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.