Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport-1.x] Kept the original constructor for PluginInfo to maintain bwc (#1206) #1209

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

VachaShah
Copy link
Collaborator

Signed-off-by: Vacha vachshah@amazon.com

Description

Backport #1206

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 601e5dc

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 601e5dc

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 601e5dc

@tlfeng
Copy link
Collaborator

tlfeng commented Sep 3, 2021

start gradle check

1 similar comment
@CEHENKLE
Copy link
Member

CEHENKLE commented Sep 3, 2021

start gradle check

@CEHENKLE
Copy link
Member

CEHENKLE commented Sep 3, 2021

Curses! lost the race to your lightening fast fingers, @tlfeng ! ;) ;) ;)

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 601e5dc
Log 487

Reports 487

@VachaShah VachaShah added v1.1.0 Issues, PRs, related to the 1.1.0 release backport PRs or issues specific to backporting features or enhancments labels Sep 3, 2021
@tlfeng
Copy link
Collaborator

tlfeng commented Sep 3, 2021

@CEHENKLE Appreciate your compliment!

@VachaShah VachaShah requested review from tlfeng and removed request for tlfeng September 3, 2021 02:00
@dblock dblock merged commit ba9c8c0 into opensearch-project:1.x Sep 3, 2021
@VachaShah
Copy link
Collaborator Author

Thank you @dblock !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments v1.1.0 Issues, PRs, related to the 1.1.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants