Kept the original constructor for PluginInfo to maintain bwc #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Gradle Wrapper Validation success 266b2c345385bfb19fc6ff61e813f75e43da310b |
|
✅ DCO Check Passed 266b2c345385bfb19fc6ff61e813f75e43da310b |
|
✅ Gradle Precommit success 266b2c345385bfb19fc6ff61e813f75e43da310b |
dblock
requested changes
Sep 2, 2021
| private final List<String> extendedPlugins; | ||
| private final boolean hasNativeController; | ||
| private String customFolderName; |
There was a problem hiding this comment.
Why is this changing? Constructor should default it to null.
| * @param extendedPlugins other plugins this plugin extends through SPI | ||
| * @param hasNativeController whether or not the plugin has a native controller | ||
| */ | ||
| public PluginInfo(String name, String description, String version, Version opensearchVersion, String javaVersion, |
There was a problem hiding this comment.
Can we write this constructor in terms of the other one?
There was a problem hiding this comment.
Makes sense! Updated it.
Signed-off-by: Vacha <vachshah@amazon.com>
VachaShah
force-pushed
the
issue-1190
branch
from
266b2c3
to
d732b29
Compare
|
✅ Gradle Wrapper Validation success d732b29 |
|
✅ DCO Check Passed d732b29 |
|
✅ Gradle Precommit success d732b29 |
dblock
approved these changes
Sep 3, 2021
|
start gradle check |
VachaShah
added a commit
to VachaShah/OpenSearch
that referenced
this pull request
Sep 3, 2021
…rch-project#1206) Signed-off-by: Vacha <vachshah@amazon.com>
5 tasks
dblock
pushed a commit
that referenced
this pull request
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vacha vachshah@amazon.com
Description
Keeping the original constructor for PluginInfo which was changed in PR #848 to add a new parameter. Restoring the original one so that if anything depends on it, it does not break.
Issues Resolved
#1190
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.