Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep original constructor of PluginInfo while we support custom folder name #1190

Closed
ylwu-amzn opened this issue Aug 31, 2021 · 3 comments
Closed

Keep original constructor of PluginInfo while we support custom folder name #1190

ylwu-amzn opened this issue Aug 31, 2021 · 3 comments
Assignees
@VachaShah
Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request v1.1.0 Issues, PRs, related to the 1.1.0 release

Comments

@ylwu-amzn
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In PR #848, we changed PluginInfo constructor by adding customFolderName

public PluginInfo(String name, String description, String version, Version opensearchVersion, String javaVersion,
String classname, String customFolderName, List extendedPlugins, boolean hasNativeController)

Is it possible to keep the original constructor and add a new constructor to support customFolderName ? This change caused AD test case failed. Not a big problem, but we'd better make the change backward compatible.

Describe the solution you'd like
Keep the original PluginInfo constructor for BWC.
@ylwu-amzn ylwu-amzn added the enhancement Enhancement or improvement to existing feature or request label Aug 31, 2021
@ylwu-amzn ylwu-amzn mentioned this issue Aug 31, 2021
Merged
5 tasks
@dblock
Copy link
Member

dblock commented Aug 31, 2021

@VachaShah Can you take it for 1.1?

@dblock dblock added v1.1.0 Issues, PRs, related to the 1.1.0 release Build Libraries & Interfaces labels Aug 31, 2021
@VachaShah
Copy link
Collaborator

Sure I can take this up.

@VachaShah VachaShah self-assigned this Aug 31, 2021
@VachaShah VachaShah mentioned this issue Sep 2, 2021
Merged
5 tasks
@VachaShah
Copy link
Collaborator

Backported the change to 1.x: #1209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VachaShah VachaShah

Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request v1.1.0 Issues, PRs, related to the 1.1.0 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dblock @VachaShah @ylwu-amzn