Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS] Bug-fix Fix data source picker trigger local cluster call by default #7528

Merged

Conversation

RyanL1997
Copy link
Contributor

@RyanL1997 RyanL1997 commented Jul 26, 2024

Description

Fix data source picker trigger local cluster call by default

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: Fix data source picker trigger local cluster call by default

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.65%. Comparing base (339836f) to head (be61f2d).

Files Patch % Lines
...ion/manage_direct_query_data_connections_table.tsx 33.33% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7528   +/-   ##
=======================================
  Coverage   63.65%   63.65%           
=======================================
  Files        3629     3629           
  Lines       79519    79521    +2     
  Branches    12602    12605    +3     
=======================================
+ Hits        50616    50618    +2     
  Misses      25835    25835           
  Partials     3068     3068           
Flag Coverage Δ
Linux_1 30.76% <ø> (ø)
Linux_2 55.58% <ø> (ø)
Linux_3 40.23% <33.33%> (+<0.01%) ⬆️
Linux_4 31.57% <ø> (ø)
Windows_1 30.78% <ø> (ø)
Windows_2 55.53% <ø> (ø)
Windows_3 40.24% <33.33%> (-0.01%) ⬇️
Windows_4 31.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
@RyanL1997
Copy link
Contributor Author

└-: 5.6 urls
               └-> "before all" hook for "url with filters and query"
               └-> url with filters and query
                 └-> "before each" hook: global before each for "url with filters and query"
                 └- × fail: dashboard app using legacy data bwc shared urls 5.6 urls url with filters and query
                 │      Error: expected '' to equal 'memory:>220000'
                 │       at Assertion.assert (packages\osd-expect\expect.js:111:11)
                 │       at Assertion.equal (packages\osd-expect\expect.js:[238](https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/10120611994/job/28000697438?pr=7528#step:18:239):8)
                 │       at Context.<anonymous> (test\functional\apps\dashboard\/bwc_shared_urls.js:101:26)
                 │       at processTicksAndRejections (node:internal/process/task_queues:95:5)
                 │       at Object.apply (packages\osd-test\src\functional_test_runner\lib\mocha\wrap_function.js:95:16)
                 │ 
                 │

seems unrelated to the change, and it is only happens on the windows runner

@ananzh ananzh merged commit 5f19c37 into opensearch-project:main Jul 29, 2024
126 of 130 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 29, 2024
…fault (#7528)

* Fux data source picker trigger local cluster call by default

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR #7528 created/updated

* Fux data source picker trigger local cluster call by default 2

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 5f19c37)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 29, 2024
…fault (#7528)

* Fux data source picker trigger local cluster call by default

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR #7528 created/updated

* Fux data source picker trigger local cluster call by default 2

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 5f19c37)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh pushed a commit that referenced this pull request Jul 30, 2024
…fault (#7528) (#7562)

* Fux data source picker trigger local cluster call by default



* Changeset file for PR #7528 created/updated

* Fux data source picker trigger local cluster call by default 2



---------



(cherry picked from commit 5f19c37)

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lu Yu <nluyu@amazon.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024
…fault (opensearch-project#7528)

* Fux data source picker trigger local cluster call by default

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR opensearch-project#7528 created/updated

* Fux data source picker trigger local cluster call by default 2

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants