Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.16] [MDS] Bug-fix Fix data source picker trigger local cluster call by default #7563

Closed
wants to merge 1 commit into from
Closed

[Backport 2.16] [MDS] Bug-fix Fix data source picker trigger local cluster call by default #7563

wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 5f19c37 from #7528.

@github-actions @opensearch-changeset-bot
[MDS] Bug-fix Fix data source picker trigger local cluster call by de…
f2bb2ea 
…fault (#7528)

* Fux data source picker trigger local cluster call by default

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR #7528 created/updated

* Fux data source picker trigger local cluster call by default 2

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 5f19c37)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports valued-contributor v2.16.0 labels Jul 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.37%. Comparing base (7b1f742) to head (f2bb2ea).

❗ There is a different number of reports uploaded between BASE (7b1f742) and HEAD (f2bb2ea). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (7b1f742) HEAD (f2bb2ea)
Linux_3 1 0
Windows_3 1 0
Additional details and impacted files 
@@            Coverage Diff             @@
##             2.16    #7563      +/-   ##
==========================================
- Coverage   63.74%   54.37%   -9.37%     
==========================================
  Files        3628     3248     -380     
  Lines       79498    70619    -8879     
  Branches    12590    10823    -1767     
==========================================
- Hits        50676    38400   -12276     
- Misses      25759    30199    +4440     
+ Partials     3063     2020    -1043
Flag Coverage Δ
Linux_1 30.77% <ø> (ø)
Linux_2 55.70% <ø> (ø)
Linux_3 ?
Linux_4 31.71% <ø> (ø)
Windows_2 55.65% <ø> (ø)
Windows_3 ?
Windows_4 31.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh
Copy link
Member

ananzh commented Jul 30, 2024

we will recut 2.16. close this bp.

@ananzh ananzh closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports failed changeset v2.16.0 valued-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ananzh