Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [MDS] Bug-fix Fix data source picker trigger local cluster call by default #7562

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 5f19c37 from #7528.

…fault (#7528)

* Fux data source picker trigger local cluster call by default

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR #7528 created/updated

* Fux data source picker trigger local cluster call by default 2

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 5f19c37)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.75%. Comparing base (ec4ee8d) to head (cb74f20).

Files Patch % Lines
...ion/manage_direct_query_data_connections_table.tsx 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7562      +/-   ##
==========================================
- Coverage   63.76%   63.75%   -0.01%     
==========================================
  Files        3628     3628              
  Lines       79498    79500       +2     
  Branches    12590    12593       +3     
==========================================
- Hits        50688    50686       -2     
- Misses      25747    25750       +3     
- Partials     3063     3064       +1     
Flag Coverage Δ
Linux_1 30.77% <ø> (ø)
Linux_2 55.70% <ø> (ø)
Linux_3 40.29% <33.33%> (-0.01%) ⬇️
Linux_4 31.71% <ø> (-0.01%) ⬇️
Windows_1 30.79% <ø> (ø)
Windows_2 55.65% <ø> (ø)
Windows_3 40.29% <33.33%> (-0.01%) ⬇️
Windows_4 31.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh
Copy link
Member

ananzh commented Jul 30, 2024

Wait for test passing

@RyanL1997
Copy link
Contributor

                 └- ✖ fail: dashboard app using legacy data bwc shared urls 5.6 urls url with filters and query
                 │      Error: expected '' to equal 'memory:>220000'
                 │       at Assertion.assert (packages/osd-expect/expect.js:111:11)
                 │       at Assertion.equal (packages/osd-expect/expect.js:238:8)
                 │       at Context.<anonymous> (test/functional/apps/dashboard/bwc_shared_urls.js:101:26)
                 │       at processTicksAndRejections (node:internal/process/task_queues:95:5)
                 │       at Object.apply (packages/osd-test/src/functional_test_runner/lib/mocha/wrap_function.js:95:16)
                 │ 

I think we also need to await for the above error fix to be merged/backported and re-run the test.

@ananzh ananzh merged commit dc522de into 2.x Jul 30, 2024
61 of 65 checks passed
@ananzh
Copy link
Member

ananzh commented Jul 30, 2024

Will re-run all the tests later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset v2.16.0 valued-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants