-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[navigation-next] fix: redirect to standard index pattern applications while nav group is enabled #7305
[navigation-next] fix: redirect to standard index pattern applications while nav group is enabled #7305
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/navigation-next #7305 +/- ##
===========================================================
+ Coverage 67.71% 67.73% +0.02%
===========================================================
Files 3518 3518
Lines 69638 69643 +5
Branches 11365 11365
===========================================================
+ Hits 47153 47175 +22
+ Misses 19696 19681 -15
+ Partials 2789 2787 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update after video (think its the same as before)?
Thanks for catching this, updated with correct video. |
padding: $ouiSize / 4 $ouiSize; | ||
border-radius: $ouiSize; | ||
padding: calc($euiSize / 4) $euiSize; | ||
border-radius: $euiSize; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes expected? Seems unrelated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is expected, as @AMoo-Miki suggested me to do so.
7f85fe9
to
3670a30
Compare
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
eb7afb2
to
dfbda01
Compare
2c708e3
into
opensearch-project:feature/navigation-next
…s while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7305 created/updated * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update with comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update order and remove reset logic Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some category change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update category Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 2c708e3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…s while nav group is enabled (#7346) * [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7305 created/updated * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update with comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update order and remove reset logic Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some category change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update category Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 2c708e3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: change the order Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: hide left navigation when workspace enabled Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
…s while nav group is enabled (#7346) * [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7305 created/updated * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update with comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update order and remove reset logic Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some category change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update category Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 2c708e3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: change the order Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: hide left navigation when workspace enabled Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit d30677d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…s while nav group is enabled (#7346) (#7352) * [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR #7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- (cherry picked from commit 2c708e3) * feat: change the order * feat: hide left navigation when workspace enabled --------- (cherry picked from commit d30677d) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7305 created/updated * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update with comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update order and remove reset logic Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some category change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update category Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix: bugs found in integration test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: revert back detect category Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7305 created/updated * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update with comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update order and remove reset logic Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some category change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update category Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix: bugs found in integration test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: revert back detect category Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 8b46c44) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR #7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- * fix: bugs found in integration test * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case * fix: unit test error * feat: revert back detect category --------- (cherry picked from commit 8b46c44) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…roject#7377) * [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (opensearch-project#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR opensearch-project#7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- * fix: bugs found in integration test * Changeset file for PR opensearch-project#7356 created/updated * feat: show workspace detail in all use case * fix: unit test error * feat: revert back detect category --------- (cherry picked from commit 8b46c44) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 6551af7)
* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR #7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- * fix: bugs found in integration test * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case * fix: unit test error * feat: revert back detect category --------- (cherry picked from commit 8b46c44) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 6551af7) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR #7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- * fix: bugs found in integration test * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case * fix: unit test error * feat: revert back detect category --------- (cherry picked from commit 8b46c44) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 6551af7) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> (cherry picked from commit 7adc980) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR #7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- * fix: bugs found in integration test * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case * fix: unit test error * feat: revert back detect category --------- (cherry picked from commit 8b46c44) (cherry picked from commit 6551af7) (cherry picked from commit 7adc980) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR #7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- * fix: bugs found in integration test * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case * fix: unit test error * feat: revert back detect category --------- (cherry picked from commit 8b46c44) (cherry picked from commit 6551af7) (cherry picked from commit 7adc980) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> (cherry picked from commit 0429e8a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR #7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- * fix: bugs found in integration test * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case * fix: unit test error * feat: revert back detect category --------- (cherry picked from commit 8b46c44) (cherry picked from commit 6551af7) (cherry picked from commit 7adc980) (cherry picked from commit 0429e8a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Description
When nav group is enabled and users want to visit
Dashboards
page if no index pattern is configured in their OSD, OSD will direct user to the index pattern page, which is a sub app under management.This PR is mainly to solve this problem by redirecting users to the right application.
Issues Resolved
Screenshot
Before the fix
20240718214149613.mp4
After the fix
20240718214309128.mp4
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration