Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation-next] fix: redirect to standard index pattern applications while nav group is enabled #7346

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Jul 21, 2024

Backport 2c708e3 from #7305.

Description

When nav group is enabled and users want to visit Dashboards page if no index pattern is configured in their OSD, OSD will direct user to the index pattern page, which is a sub app under management.

This PR is mainly to solve this problem by redirecting users to the right application.

  • Address the issue that in-app navigation is not hide when nav group is enabled.
  • Address the issue that the app will still navigate to legacy index pattern management page.
  • Address the scss code concern from @AMoo-Miki
  • Hide new left navigation in home page when workspace is enabled.
  • Group all the registered applications with nav group info to custom category.

Screenshot

Before the fix

20240718214149613.mp4

After the fix

20240718214309128.mp4

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…s while nav group is enabled (#7305)

* feat: fix the incorrect jumping logic for Index pattern management

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7305 created/updated

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update with comment

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update order and remove reset logic

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some category change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update category

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2c708e3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.70%. Comparing base (376ead0) to head (9c0b149).
Report is 1 commits behind head on main.

Files Patch % Lines
...chrome/ui/header/collapsible_nav_group_enabled.tsx 75.00% 1 Missing and 2 partials ⚠️
.../plugins/index_pattern_management/public/plugin.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7346      +/-   ##
==========================================
- Coverage   67.72%   67.70%   -0.02%     
==========================================
  Files        3518     3519       +1     
  Lines       69638    69685      +47     
  Branches    11365    11374       +9     
==========================================
+ Hits        47165    47183      +18     
- Misses      19684    19708      +24     
- Partials     2789     2794       +5     
Flag Coverage Δ
Linux_1 33.19% <7.69%> (+0.02%) ⬆️
Linux_2 55.46% <75.00%> (-0.01%) ⬇️
Linux_3 43.32% <9.09%> (+<0.01%) ⬆️
Linux_4 34.70% <40.90%> (+0.01%) ⬆️
Windows_1 33.21% <7.69%> (+<0.01%) ⬆️
Windows_2 55.41% <75.00%> (-0.01%) ⬇️
Windows_3 43.33% <9.09%> (-0.01%) ⬇️
Windows_4 34.70% <40.90%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe changed the title [Backport main] [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled Jul 22, 2024
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Jul 22, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe merged commit d30677d into main Jul 22, 2024
74 of 75 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 22, 2024
…s while nav group is enabled (#7346)

* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305)

* feat: fix the incorrect jumping logic for Index pattern management

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7305 created/updated

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update with comment

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update order and remove reset logic

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some category change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update category

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2c708e3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: change the order

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide left navigation when workspace enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit d30677d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe added a commit that referenced this pull request Jul 22, 2024
…s while nav group is enabled (#7346) (#7352)

* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305)

* feat: fix the incorrect jumping logic for Index pattern management



* Changeset file for PR #7305 created/updated

* feat: update



* feat: update with comment



* feat: update order and remove reset logic



* feat: update



* feat: update



* feat: update snapshot



* feat: some category change



* feat: update category



---------



(cherry picked from commit 2c708e3)


* feat: change the order



* feat: hide left navigation when workspace enabled



---------






(cherry picked from commit d30677d)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor autocut Skip the changelog verification check on backports backport 2.x distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants