Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix navigation issue across dashboards #5435

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Fix navigation issue across dashboards #5435

merged 2 commits into from
Nov 7, 2023

Conversation

abbyhu2000
Copy link
Member

@abbyhu2000 abbyhu2000 commented Nov 6, 2023 •
edited
Loading

Description

Add a dashboard id as a prop to pass into the to force react to rerender the component everytime it receives a new id.

Issues Resolved

resolves #4694
resolves #4819

Screenshot

Screen.Recording.2023-11-06.at.8.46.07.AM.mov
Screen.Recording.2023-11-06.at.3.12.04.PM.mov

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@abbyhu2000
Adding id to force react to rerender
035f016 
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@abbyhu2000 abbyhu2000 self-assigned this Nov 6, 2023
@abbyhu2000 abbyhu2000 added dashboards de-angular de-angularize work labels Nov 6, 2023
@abbyhu2000
changelog
c68f2b0 
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023 •
edited
Loading

Codecov Report

Merging #5435 (c68f2b0) into main (abc97ea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5435   +/-   ##
=======================================
  Coverage   66.78%   66.78%           
=======================================
  Files        3291     3291           
  Lines       63174    63174           
  Branches    10055    10055           
=======================================
  Hits        42191    42191           
+ Misses      18573    18497   -76     
- Partials     2410     2486   +76
Flag Coverage Δ
Linux_1 35.24% <ø> (ø)
Linux_2 55.28% <ø> (?)
Linux_3 43.79% <ø> (-0.02%) ⬇️
Linux_4 35.34% <ø> (ø)
Windows_1 35.26% <ø> (ø)
Windows_2 ?
Windows_3 ?
Windows_4 35.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lic/application/embeddable/dashboard_container.tsx 70.83% <ø> (ø)

... and 27 files with indirect coverage changes

@abbyhu2000 abbyhu2000 added v2.11.1 Issues targeting release v2.11.1 backport 2.x backport 2.11 labels Nov 6, 2023
@abbyhu2000 abbyhu2000 merged commit 1de8be6 into opensearch-project:main Nov 7, 2023
76 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 7, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 7, 2023
@github-actions
Fix navigation bug from dashboard to dashboard (#5435)
51c96eb 
Previously navigating from one dashboard to another dashboard do not work. This PR adds a dashboard id as a prop to pass into the <DashboardViewPort> component in order to force react to re-render every time it receives a new id.

Resolve the following issues:
* #4694
* https://github.com/opensearch-project/Open and Search-Dashboards/issues/4819

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 1de8be6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 7, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 7, 2023
@github-actions
Fix navigation bug from dashboard to dashboard (#5435)
a707133 
Previously navigating from one dashboard to another dashboard do not work. This PR adds a dashboard id as a prop to pass into the <DashboardViewPort> component in order to force react to re-render every time it receives a new id.

Resolve the following issues:
* #4694
* https://github.com/opensearch-project/Open and Search-Dashboards/issues/4819

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 1de8be6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@juergen-walter juergen-walter mentioned this pull request Nov 7, 2023
Closed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 7, 2023
Closed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 7, 2023
@github-actions
Fix navigation bug from dashboard to dashboard (#5435)
150b6f3 
Previously navigating from one dashboard to another dashboard do not work. This PR adds a dashboard id as a prop to pass into the <DashboardViewPort> component in order to force react to re-render every time it receives a new id.

Resolve the following issues:
* #4694
* https://github.com/opensearch-project/Open and Search-Dashboards/issues/4819

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 1de8be6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
abbyhu2000 pushed a commit that referenced this pull request Nov 9, 2023
@opensearch-trigger-bot @github-actions
Fix navigation bug from dashboard to dashboard (#5435) (#5437)
ce72604 
Previously navigating from one dashboard to another dashboard do not work. This PR adds a dashboard id as a prop to pass into the <DashboardViewPort> component in order to force react to re-render every time it receives a new id.

Resolve the following issues:
* #4694
* https://github.com/opensearch-project/Open and Search-Dashboards/issues/4819

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 1de8be6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000 pushed a commit that referenced this pull request Nov 9, 2023
@opensearch-trigger-bot @github-actions
Fix navigation bug from dashboard to dashboard (#5435) (#5438)
2aea421 
Previously navigating from one dashboard to another dashboard do not work. This PR adds a dashboard id as a prop to pass into the <DashboardViewPort> component in order to force react to re-render every time it receives a new id.

Resolve the following issues:
* #4694
* https://github.com/opensearch-project/Open and Search-Dashboards/issues/4819

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 1de8be6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Nov 15, 2023
@AMoo-Miki
Fix navigation bug from dashboard to dashboard (opensearch-project#5435)
662b3ea 
Previously navigating from one dashboard to another dashboard do not work. This PR adds a dashboard id as a prop to pass into the <DashboardViewPort> component in order to force react to re-render every time it receives a new id.

Resolve the following issues:
* opensearch-project#4694
* https://github.com/opensearch-project/Open and Search-Dashboards/issues/4819

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

(cherry picked from commit 1de8be6)
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki AMoo-Miki mentioned this pull request Nov 15, 2023
Closed
AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Nov 16, 2023
@AMoo-Miki
Fix navigation bug from dashboard to dashboard (cherry picked from co…
079cdb5 
…mmit 1de8be6 from opensearch-project#5435)

Also:
* Lock chromedriver to v116 which is the last one compatible with Node 16
* Bump caniuse-lite db.
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Nov 16, 2023
@AMoo-Miki
Fix navigation bug from dashboard to dashboard (cherry picked from co…
3d40f82 
…mmit 1de8be6 from opensearch-project#5435)

Also:
* Lock chromedriver to v116 which is the last one compatible with Node 16
* Bump caniuse-lite db.
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Nov 16, 2023
@AMoo-Miki
Fix navigation bug from dashboard to dashboard (cherry picked from co…
6e32fc0 
…mmit 1de8be6 from opensearch-project#5435)

Also:
* Lock chromedriver to v116 which is the last one compatible with Node 16
* Bump caniuse-lite db.
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Nov 20, 2023
@AMoo-Miki
Fix navigation bug from dashboard to dashboard (cherry picked from co…
40507d1 
…mmit 1de8be6 from opensearch-project#5435)

Also:
* Lock chromedriver to v116 which is the last one compatible with Node 16
* Bump caniuse-lite db.
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Nov 20, 2023
@AMoo-Miki
Fix navigation bug from dashboard to dashboard (cherry picked from co…
a577497 
…mmit 1de8be6 from opensearch-project#5435)

Also:
* Lock chromedriver to v116 which is the last one compatible with Node 16
* Bump caniuse-lite db.
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Nov 21, 2023
@AMoo-Miki
Fix navigation bug from dashboard to dashboard (cherry picked from co…
7508750 
…mmit 1de8be6 from opensearch-project#5435)

Also:
* Lock chromedriver to v116 which is the last one compatible with Node 16
* Bump caniuse-lite db.
Signed-off-by: Miki <miki@amazon.com>
@AlexRuiz7 AlexRuiz7 mentioned this pull request Dec 18, 2023
Closed
4 tasks
AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Dec 21, 2023
@AMoo-Miki
Fix navigation bug from dashboard to dashboard (cherry picked from co…
7ca504f 
…mmit 1de8be6 from opensearch-project#5435)

Also:
* Lock chromedriver to v116 which is the last one compatible with Node 16
* Bump caniuse-lite db.
Signed-off-by: Miki <miki@amazon.com>
@AlexRuiz7 AlexRuiz7 mentioned this pull request Dec 26, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@ananzh ananzh ananzh approved these changes

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq curq is a code owner

Assignees

@abbyhu2000 abbyhu2000

Labels
backport 2.x dashboards de-angular de-angularize work distinguished-contributor v2.11.1 Issues targeting release v2.11.1
Projects
None yet
Milestone
No milestone
3 participants
@abbyhu2000 @kavilla @ananzh