[Manual backport 2.9] Fix navigation bug from dashboard to dashboard (#5435) #5481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
ananzh,
kavilla,
seanneumann,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
AMoo-Miki
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.9 #5481 +/- ##
=======================================
Coverage 66.17% 66.18%
=======================================
Files 3315 3315
Lines 63891 63887 -4
Branches 9970 9970
=======================================
+ Hits 42283 42284 +1
+ Misses 19167 19163 -4
+ Partials 2441 2440 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AMoo-Miki
force-pushed
the
2.9-backport-5435
branch
from
662b3ea
to
079cdb5
Compare
AMoo-Miki
force-pushed
the
2.9-backport-5435
branch
2 times, most recently
from
3d40f82
to
6e32fc0
Compare
ananzh
previously approved these changes
Nov 20, 2023
|
Why aren't the test running for this PR? |
|
It says startup failure here: |
AMoo-Miki
force-pushed
the
2.9-backport-5435
branch
3 times, most recently
from
a577497
to
7508750
Compare
AMoo-Miki
force-pushed
the
2.9-backport-5435
branch
3 times, most recently
from
f8cf495
to
0884c63
Compare
AMoo-Miki
force-pushed
the
2.9-backport-5435
branch
3 times, most recently
from
a732702
to
f333704
Compare
…mmit 1de8be6 from opensearch-project#5435) Also: * Lock chromedriver to v116 which is the last one compatible with Node 16 * Bump caniuse-lite db. Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
2.9-backport-5435
branch
from
f333704
to
7ca504f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix navigation bug from dashboard to dashboard (cherry picked from commit 1de8be6 from #5435)
Also:
Signed-off-by: Miki miki@amazon.com