Skip to content

Commit

Permalink
Fix navigation bug from dashboard to dashboard (#5435)
Browse files Browse the repository at this point in the history
Previously navigating from one dashboard to another dashboard do not work. This PR adds a dashboard id as a prop to pass into the <DashboardViewPort> component in order to force react to re-render every time it receives a new id.

Resolve the following issues:
* #4694
* https://github.com/opensearch-project/Open and Search-Dashboards/issues/4819

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 1de8be6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
  • Loading branch information
github-actions[bot] committed Nov 7, 2023
1 parent 227a412 commit a707133
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ export class DashboardContainer extends Container<InheritedChildInput, Dashboard
<I18nProvider>
<OpenSearchDashboardsContextProvider services={this.options}>
<DashboardViewport
key={this.id}
renderEmpty={this.renderEmpty}
logos={this.logos}
container={this}
Expand Down

0 comments on commit a707133

Please sign in to comment.