Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(io-engine): use SafeMountIter instead of proc_mounts::MountIter #1591

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

niladrih
Copy link
Member

@niladrih niladrih commented Feb 19, 2024

Changes:

  • Removes proc_mounts as a dependency.
  • Adds utils/dependencies/devinfo as a depdency
  • Uses devinfo::mountinfo::SafeMountIter in place of proc_mounts::MountIter

Ref:

@niladrih
Copy link
Member Author

bors try

@bors-openebs-mayastor
Copy link

try

Build failed:

@niladrih
Copy link
Member Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 19, 2024
@bors-openebs-mayastor
Copy link

try

Build failed:

@niladrih
Copy link
Member Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 19, 2024
@bors-openebs-mayastor
Copy link

try

Build failed:

@niladrih
Copy link
Member Author

error[E0046]: not all trait items implemented, missing: `resize_nexus`

   --> io-engine/src/grpc/v1/nexus.rs:392:1

    |

392 | impl NexusRpc for NexusService {

    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `resize_nexus` in implementation

    |

    = help: implement the missing item: `fn resize_nexus(&'life0 self, _: tonic::Request<io_engine_api::v1::nexus::ResizeNexusRequest>) -> std::pin::Pin<std::boxed::Box<(dyn futures::Future<Output = std::result::Result<tonic::Response<io_engine_api::v1::nexus::ResizeNexusResponse>, tonic::Status>> + std::marker::Send + 'async_trait)>> { todo!() }`

For more information about this error, try `rustc --explain E0046`.

error: could not compile `io-engine` (lib) due to previous error

warning: build failed, waiting for other jobs to finish...

error: could not compile `io-engine` (lib) due to previous error

Requires #1590

@tiagolobocastro
Copy link
Contributor

This is what I alluded to during the standup, ideally we should not merge dependency PR's until the PR that makes use of it or a dummy handle PR is ready to merge here/control-plane

bors-openebs-mayastor bot pushed a commit to openebs/mayastor-control-plane that referenced this pull request Feb 20, 2024
749: refactor(csi-driver): replace MountIters with SafeMountIters r=niladrih a=niladrih

Changes:
- Replaces MountIters with SafeMountIters.

Ref:
- openebs/mayastor-dependencies#65
- openebs/mayastor#1591

Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
@niladrih niladrih force-pushed the mount-iter branch 2 times, most recently from 24b9463 to a2dc269 Compare February 21, 2024 06:58
@niladrih
Copy link
Member Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 21, 2024
@bors-openebs-mayastor
Copy link

try

Build succeeded:

io-engine/src/host/blk_device.rs Outdated Show resolved Hide resolved
@niladrih niladrih force-pushed the mount-iter branch 2 times, most recently from c39dc97 to b10e281 Compare February 21, 2024 12:05
@niladrih
Copy link
Member Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 21, 2024
@bors-openebs-mayastor
Copy link

try

Build failed:

@niladrih
Copy link
Member Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 21, 2024
@niladrih
Copy link
Member Author

bors cancel

@bors-openebs-mayastor
Copy link

try

Build succeeded:

Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@niladrih
Copy link
Member Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 21, 2024
@niladrih
Copy link
Member Author

bors merge

@bors-openebs-mayastor
Copy link

try

Build succeeded:

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 098097a into develop Feb 21, 2024
4 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the mount-iter branch February 21, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants