fix(devinfo): add consistent read for kernel bug #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niladrih
requested review from
dsavitskiy,
tiagolobocastro,
avishnu and
Abhinandan-Purkait
|
@tiagolobocastro and others -- should I remove the MountIter::new() API as I intend to refactor control-plane and mayastor to use SafeMountIter instead? |
|
Is the linter CI issue because of std::sync::OnceLock? |
Non-related, @datacore-vvarakantham is fixing this |
We need to keep I think, otherwise you can't merge this PR independently to the other repos? |
Yeah, it's fine to keep it. |
tiagolobocastro
approved these changes
Feb 12, 2024
niladrih
requested review from
hrudaya21,
chriswldenyer,
abhilashshetty04 and
dsharma-dc
Abhinandan-Purkait
approved these changes
Feb 16, 2024
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
added a commit
to openebs/mayastor-control-plane
that referenced
this pull request
Feb 18, 2024
Ref: openebs/mayastor-dependencies#65 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
added a commit
to openebs/mayastor-control-plane
that referenced
this pull request
Feb 19, 2024
Ref: openebs/mayastor-dependencies#65 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
added a commit
to openebs/mayastor-control-plane
that referenced
this pull request
Feb 19, 2024
Ref: openebs/mayastor-dependencies#65 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
added a commit
to openebs/mayastor-control-plane
that referenced
this pull request
Feb 19, 2024
Ref: openebs/mayastor-dependencies#65 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
added a commit
to openebs/mayastor-control-plane
that referenced
this pull request
Feb 19, 2024
Ref: openebs/mayastor-dependencies#65 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
added a commit
to openebs/mayastor
that referenced
this pull request
Feb 19, 2024
Ref: openebs/mayastor-dependencies#65 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
added a commit
to openebs/mayastor
that referenced
this pull request
Feb 19, 2024
Ref: openebs/mayastor-dependencies#65 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
added a commit
to openebs/mayastor-control-plane
that referenced
this pull request
Feb 20, 2024
Ref: openebs/mayastor-dependencies#65 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
bors-openebs-mayastor bot
pushed a commit
to openebs/mayastor-control-plane
that referenced
this pull request
Feb 20, 2024
749: refactor(csi-driver): replace MountIters with SafeMountIters r=niladrih a=niladrih Changes: - Replaces MountIters with SafeMountIters. Ref: - openebs/mayastor-dependencies#65 - openebs/mayastor#1591 Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
added a commit
to openebs/mayastor
that referenced
this pull request
Feb 20, 2024
Ref: openebs/mayastor-dependencies#65 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
added a commit
to openebs/mayastor
that referenced
this pull request
Feb 21, 2024
Ref: openebs/mayastor-dependencies#65 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
added a commit
to openebs/mayastor
that referenced
this pull request
Feb 21, 2024
Ref: openebs/mayastor-dependencies#65 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
added a commit
to openebs/mayastor
that referenced
this pull request
Feb 21, 2024
Ref: openebs/mayastor-dependencies#65 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
added a commit
to openebs/mayastor
that referenced
this pull request
Feb 21, 2024
Ref: openebs/mayastor-dependencies#65 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
added a commit
to openebs/mayastor
that referenced
this pull request
Feb 21, 2024
Ref: openebs/mayastor-dependencies#65 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
bors-openebs-mayastor bot
pushed a commit
to openebs/mayastor
that referenced
this pull request
Feb 21, 2024
1591: refactor(io-engine): use SafeMountIter instead of proc_mounts::MountIter r=niladrih a=niladrih Changes: - Removes proc_mounts as a dependency. - Adds utils/dependencies/devinfo as a depdency - Uses devinfo::mountinfo::SafeMountIter in place of proc_mounts::MountIter Ref: - openebs/mayastor-dependencies#65 - openebs/mayastor-control-plane#749 Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes openebs/mayastor#1274
On the linux kernel versions below v5.8, there's a bug which behaves like so:
Whenever a read(2) syscall is issued (and this one takes an argument for how many bytes to read off of a file) to the
/proc/mountsvirtual file, few of the mount entries are read off of it. The kernel maintains the seek position of the file so that it can serve subsequent read(2)s from that position. But, in between the first and the second read(2), a device might be unmounted and one/few mount entries might be removed from the already-read portion of the file. This moves the mount entries after the deleted entries further up the file. However, the seek position has not changed. So, subsequent read(2)s will miss one or more read entries, as the seek position now points to a mount entry further down the list.Ref: torvalds/linux@9f6c61f
Changes:
This PR adds a
consistent_read()implementation for the interfaceMountIterfor kernel versions less than 5.8.0.consistent_read()reads the whole file twice start to end, and compares the two byte buffers. If both of the subsequent reads resulted in the same byte-sequence, then we can say we have not lost mount entries when traversing/proc/mounts, as then the comparison would fail on the second read from start to end. This is configured to default to 2 comparison retries if the first comparison fails. However that may not be enough if there are very many mount entries and the host has very frequent unmounts. Use higher retries for those cases.