Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nexus/resize): add support for resizing a nexus #1590

Merged
merged 3 commits into from
Feb 21, 2024
Merged

feat(nexus/resize): add support for resizing a nexus #1590

merged 3 commits into from
Feb 21, 2024

Conversation

dsharma-dc
Copy link
Contributor

No description provided.

@niladrih niladrih mentioned this pull request Feb 19, 2024
Merged
bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 20, 2024
Try #1590:
233d1c3
@openebs openebs deleted a comment from bors-openebs-mayastor bot Feb 20, 2024
@dsharma-dc
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 20, 2024
Try #1590:
776a475
@bors-openebs-mayastor
Copy link

try

Build failed:

@dsharma-dc
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 20, 2024
Try #1590:
7703b4a
@bors-openebs-mayastor
Copy link

try

Build succeeded:

tiagolobocastro
tiagolobocastro approved these changes Feb 20, 2024
View reviewed changes
io-engine/src/bdev/nexus/nexus_bdev.rs Outdated Show resolved Hide resolved
io-engine/src/bdev/nexus/nexus_bdev_error.rs Show resolved Hide resolved
io-engine/src/bin/io-engine-client/v1/nexus_cli.rs Outdated Show resolved Hide resolved
io-engine/src/grpc/v1/nexus.rs Outdated Show resolved Hide resolved
io-engine/tests/nexus_replica_resize.rs Show resolved Hide resolved
niladrih
niladrih approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Left one nitpick comment.

io-engine/tests/nexus_replica_resize.rs Show resolved Hide resolved
@dsharma-dc
feat(nexus/resize): add support for resizing a nexus
404234d 
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
@dsharma-dc
feat(io-engine-client): add cli for resizing a nexus
372a047 
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
@dsharma-dc
test(volume/resize): add cargo tests for volume resize
5a77c7f 
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
@dsharma-dc
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 21, 2024
Try #1590:
4efef7f
@bors-openebs-mayastor
Copy link

try

Build succeeded:

@dsharma-dc
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 51c4bb8 into openebs:develop Feb 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@niladrih niladrih niladrih approved these changes

@dsavitskiy dsavitskiy Awaiting requested review from dsavitskiy

@hrudaya21 hrudaya21 Awaiting requested review from hrudaya21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsharma-dc @tiagolobocastro @niladrih