-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code.stacktrace
attribute
#435
Add code.stacktrace
attribute
#435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we deprecate exception.stacktrace
in favor of this generalization?
@trask I wasn't intending to imply changes to But, you are right that |
Re-using a generic |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have also had use cases for including a stack trace outside of an exception and came to the same conclusion that the attribute should be named code.stacktrace
.
Thanks for beating me too it 😁!
9cfb832
to
23e7326
Compare
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
a09952a
to
72e3ed7
Compare
I didn't read everything, but please note that exception.stacktrace is not a plain stacktrace but the default detailed textual exception representation (including, usually, exception type, message, caused-by, etc). There was a long discussion about the name (IIRC I was strongly against exceptions.stacktrace since in many languages there is also the possibility to get a textual representation of just the exception stacktrace), but there is no other common name for that concept. |
Thanks @Oberon00 , that's also how I understood |
should this have a change log entry? |
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
Changes
There are use cases when it's desirable to collect a stacktrace that is not necessarily attached to an exception (e.g. to identify the exact stack of a span).
This PR proposes a new attribute
code.stacktrace
for the above-mentioned use cases.Merge requirement checklist