Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use otel semconv field for stacktrace #836

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Nov 9, 2023

Follow-up of #828, changes the otel attribute to use to code.stacktrace now that the semantic conventions PR has been merged: open-telemetry/semantic-conventions#435 and will be part of the next version.

  • Create PR as draft
  • Approval by at least one other agent
  • Mark as Ready for Review (automatically requests reviews from all agents and PM via CODEOWNERS)
    • Remove PM from reviewers if impact on product is negligible
    • Remove agents from reviewers if the change is not relevant for them
  • Merge after 2 business days passed without objections
    To auto-merge the PR, add /schedule YYYY-MM-DD to the PR description.

@SylvainJuge SylvainJuge requested review from a team as code owners November 9, 2023 14:48
@SylvainJuge SylvainJuge merged commit 3d6c713 into elastic:main Nov 14, 2023
5 checks passed
@SylvainJuge SylvainJuge deleted the semconv-stacktrace branch November 14, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants