Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTel attribute for span stacktrace capture #828

Merged
merged 5 commits into from
Oct 19, 2023
Merged

OTel attribute for span stacktrace capture #828

merged 5 commits into from
Oct 19, 2023

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Oct 17, 2023 •
edited
Loading

  • Create PR as draft
  • Approval by at least one other agent
  • Mark as Ready for Review (automatically requests reviews from all agents and PM via CODEOWNERS)
    • Remove PM from reviewers if impact on product is negligible
    • Remove agents from reviewers if the change is not relevant for them
  • Merge after 2 business days passed without objections
    To auto-merge the PR, add /schedule YYYY-MM-DD to the PR description.

@SylvainJuge SylvainJuge mentioned this pull request Oct 17, 2023
Closed
7 tasks
@SylvainJuge SylvainJuge marked this pull request as ready for review October 17, 2023 14:43
@SylvainJuge SylvainJuge requested review from a team as code owners October 17, 2023 14:43
@SylvainJuge SylvainJuge removed request for a team October 17, 2023 14:43
axw
axw approved these changes Oct 18, 2023
View reviewed changes
specs/agents/tracing-spans.md Outdated Show resolved Hide resolved
@SylvainJuge SylvainJuge merged commit 0a22543 into elastic:main Oct 19, 2023
3 checks passed
@SylvainJuge SylvainJuge deleted the otel-span-stacktrace branch October 19, 2023 07:40
@SylvainJuge
Copy link
Member Author

The proposal in otel semantic conventions is code.stacktrace , which means this change will need to be modified once open-telemetry/semantic-conventions#435 is merged.

@SylvainJuge SylvainJuge mentioned this pull request Nov 9, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basepi basepi basepi approved these changes

@axw axw axw approved these changes

@SergeyKleyman SergeyKleyman SergeyKleyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SylvainJuge @basepi @axw @SergeyKleyman