fix(angular): dynamic module federation should not reset remoteUrlDefinitions #27793 #27927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 06b65a4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
leosvelperez
approved these changes
Sep 16, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Sep 18, 2024
…initions #27793 (#27927) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> When the `@nx/angular/mf` file is loaded, it sets `remoteUrlDefinitions = {}`. As this is a global, this can lead to erroneous behaviour by resetting existing definitions. It is also always truthy, breaking logic on whether urls need to be set or not. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> The object should be conditionally set if undefined when calling `setRemoteDefinition` ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #27793, #27842 (cherry picked from commit d682bae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When the
@nx/angular/mffile is loaded, it setsremoteUrlDefinitions = {}.As this is a global, this can lead to erroneous behaviour by resetting existing definitions. It is also always truthy, breaking logic on whether urls need to be set or not.
Expected Behavior
The object should be conditionally set if undefined when calling
setRemoteDefinitionRelated Issue(s)
Fixes #27793, #27842