Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFE resolveRemoteUrl no longer working #27793

Closed
1 of 4 tasks
JacobSiegle opened this issue Sep 5, 2024 · 2 comments · Fixed by #27927
Closed
1 of 4 tasks

MFE resolveRemoteUrl no longer working #27793

JacobSiegle opened this issue Sep 5, 2024 · 2 comments · Fixed by #27927
Assignees
@Coly010
Labels
scope: module federation Issues related to module federation support type: bug

Comments

@JacobSiegle
Copy link

Current Behavior

    const remoteUrl = remoteUrlDefinitions
        ? remoteUrlDefinitions[remoteName]
        : await resolveRemoteUrl(remoteName);

remoteUrlDefinitions was changed to being an object by default not null in #27051, so the provided check always passes and resolveRemoteUrl won't be called.

Expected Behavior

resolveRemoteUrl should be called by the code

GitHub Repo

No response

Steps to Reproduce

  1. Make code that uses only setRemoteUrlResolver

Nx Report

N/A

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

NX 19.6.5
@JacobSiegle
Copy link
Author

@Coly010 @menosprezzi 4aceafa#diff-42eebccd6098f7c4bbf5b7b778ce4d9582f8f44a866e6b2e06b76f977f429a06R15

@JacobSiegle
Copy link
Author

Work around seems like doing -
setRemoteDefinitions(null);

@Coly010 Coly010 self-assigned this Sep 16, 2024
@Coly010 Coly010 added the scope: module federation Issues related to module federation support label Sep 16, 2024
Coly010 added a commit that referenced this issue Sep 16, 2024
@Coly010
fix(angular): dynamic module federation should not reset remoteUrlDef…
06b65a4 
…initions #27793
@Coly010 Coly010 mentioned this issue Sep 16, 2024
Merged
FrozenPandaz pushed a commit that referenced this issue Sep 18, 2024
@Coly010 @FrozenPandaz
fix(angular): dynamic module federation should not reset remoteUrlDef…
82470c4 
…initions #27793 (#27927)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
When the `@nx/angular/mf` file is loaded, it sets `remoteUrlDefinitions
= {}`.
As this is a global, this can lead to erroneous behaviour by resetting
existing definitions. It is also always truthy, breaking logic on
whether urls need to be set or not.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
The object should be conditionally set if undefined when calling
`setRemoteDefinition`

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #27793, #27842

(cherry picked from commit d682bae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Coly010 Coly010

Labels
scope: module federation Issues related to module federation support type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(angular): dynamic module federation should not reset remoteUrlDefinitions #27793 nrwl/nx
2 participants
@JacobSiegle @Coly010