Skip to content

Commit

Permalink
fix(angular): dynamic module federation should not reset remoteUrlDef…
Browse files Browse the repository at this point in the history
…initions #27793
  • Loading branch information
Coly010 committed Sep 16, 2024
1 parent a7aab61 commit 06b65a4
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion packages/angular/mf/mf.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,27 @@ declare const __webpack_init_sharing__: (scope: 'default') => Promise<void>;
declare const __webpack_share_scopes__: { default: unknown };

let resolveRemoteUrl: ResolveRemoteUrlFunction;

export function setRemoteUrlResolver(
_resolveRemoteUrl: ResolveRemoteUrlFunction
) {
resolveRemoteUrl = _resolveRemoteUrl;
}

let remoteUrlDefinitions: Record<string, string> = {};
let remoteUrlDefinitions: Record<string, string>;

export function setRemoteDefinitions(definitions: Record<string, string>) {
remoteUrlDefinitions = definitions;
}

export function setRemoteDefinition(remoteName: string, remoteUrl: string) {
remoteUrlDefinitions ??= {};
remoteUrlDefinitions[remoteName] = remoteUrl;
}

let remoteModuleMap = new Map<string, unknown>();
let remoteContainerMap = new Map<string, unknown>();

export async function loadRemoteModule(remoteName: string, moduleName: string) {
const remoteModuleKey = `${remoteName}:${moduleName}`;
if (remoteModuleMap.has(remoteModuleKey)) {
Expand All @@ -46,6 +50,7 @@ function loadModule(url: string) {
}

let initialSharingScopeCreated = false;

async function loadRemoteContainer(remoteName: string) {
if (!resolveRemoteUrl && !remoteUrlDefinitions) {
throw new Error(
Expand Down

0 comments on commit 06b65a4

Please sign in to comment.